threads / patch / 11074

patchSet OLD_ICONV on Cygwin.

Subject: [PATCH] Set OLD_ICONV on Cygwin.

## tl;dr

3 messages between Dec 1, 2007 and Dec 4, 2007. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Pascal Obry· Dec 1, 2007, 09:49 UTC · lore

Cygwin still has old definition for the iconv() second parameter. This patch fixes the last warning on Cygwin. This has been tested with Cygwin 1.5.24.

Signed-off-by: Pascal Obry <pascal@obry.net>
---
 Makefile |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to Makefile +1 −0

diff --git a/Makefile b/Makefile
index e869b85..fa3398c 100644
--- a/Makefile
+++ b/Makefile
@@ -446,6 +446,7 @@ ifeq ($(uname_O),Cygwin)
 	NEEDS_LIBICONV = YesPlease
 	NO_FAST_WORKING_DIRECTORY = UnfortunatelyYes
 	NO_TRUSTABLE_FILEMODE = UnfortunatelyYes
+	OLD_ICONV = UnfortunatelyYes
 	# There are conflicting reports about this.
 	# On some boxes NO_MMAP is needed, and not so elsewhere.
 	# Try commenting this out if you suspect MMAP is more efficient

-- 
1.5.3.6.985.g65c6a4

Pascal Obry· Dec 3, 2007, 18:49 UTC · re: Pascal Obry · lore

Re: [PATCH] Set OLD_ICONV on Cygwin.

I pretty well understand that this patch is not very important but since I got no reply I'm wondering if there is something wrong with it ?

Pascal.

-- 
--|------------------------------------------------------
--| Pascal Obry                           Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--|              http://www.obry.net
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver wwwkeys.pgp.net --recv-key C1082595

Andreas Ericsson· Dec 4, 2007, 09:32 UTC · re: Pascal Obry · lore

Re: [PATCH] Set OLD_ICONV on Cygwin.

Pascal Obry wrote:

> I pretty well understand that this patch is not very important but since
> I got no reply I'm wondering if there is something wrong with it ?
>

Only one, insofar as I can see; You didn't CC Junio. He probably missed it.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231