git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Set OLD_ICONV on Cygwin.

From
Pascal Obry <pascal.obry@gmail.com>
Date
Dec 1, 2007, 09:49 UTC
Message-ID
<1196502562-1052-1-git-send-email-pascal@obry.net>

Cygwin still has old definition for the iconv() second parameter. This patch fixes the last warning on Cygwin. This has been tested with Cygwin 1.5.24.

Signed-off-by: Pascal Obry <pascal@obry.net>
---
 Makefile |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile
index e869b85..fa3398c 100644
--- a/Makefile
+++ b/Makefile
@@ -446,6 +446,7 @@ ifeq ($(uname_O),Cygwin)
 	NEEDS_LIBICONV = YesPlease
 	NO_FAST_WORKING_DIRECTORY = UnfortunatelyYes
 	NO_TRUSTABLE_FILEMODE = UnfortunatelyYes
+	OLD_ICONV = UnfortunatelyYes
 	# There are conflicting reports about this.
 	# On some boxes NO_MMAP is needed, and not so elsewhere.
 	# Try commenting this out if you suspect MMAP is more efficient
-- 
1.5.3.6.985.g65c6a4
Next: Pascal Obry
Message 1 of 3 in “Set OLD_ICONV on Cygwin.”
  1. Set OLD_ICONV on Cygwin.Pascal Obry, Dec 1, 2007
  2. Pascal ObryDec 3, 2007
  3. Andreas EricssonDec 4, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.