{"thread":{"id":"11074","subject":"[PATCH] Set OLD_ICONV on Cygwin.","startedAt":"2007-12-01T09:49:22Z","lastAt":"2007-12-04T09:32:43Z","messageCount":3,"participants":["Pascal Obry","Andreas Ericsson"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"61570","messageId":"1196502562-1052-1-git-send-email-pascal@obry.net","threadId":"11074","inReplyTo":null,"subject":"[PATCH] Set OLD_ICONV on Cygwin.","fromName":"Pascal Obry","fromEmail":"pascal.obry@gmail.com","sentAt":"2007-12-01T09:49:22Z","receivedAt":"2007-12-01T09:49:22Z","isPatch":true,"sender":{"key":"pascal@obry.net","avatar":"https://avatars.githubusercontent.com/u/467069?v=4"},"body":"Cygwin still has old definition for the iconv() second\nparameter. This patch fixes the last warning on Cygwin.\nThis has been tested with Cygwin 1.5.24.\n\nSigned-off-by: Pascal Obry <pascal@obry.net>\n---\n Makefile |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex e869b85..fa3398c 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -446,6 +446,7 @@ ifeq ($(uname_O),Cygwin)\n \tNEEDS_LIBICONV = YesPlease\n \tNO_FAST_WORKING_DIRECTORY = UnfortunatelyYes\n \tNO_TRUSTABLE_FILEMODE = UnfortunatelyYes\n+\tOLD_ICONV = UnfortunatelyYes\n \t# There are conflicting reports about this.\n \t# On some boxes NO_MMAP is needed, and not so elsewhere.\n \t# Try commenting this out if you suspect MMAP is more efficient\n-- \n1.5.3.6.985.g65c6a4\n"},{"id":"61810","messageId":"47544FC7.3070100@obry.net","threadId":"11074","inReplyTo":"1196502562-1052-1-git-send-email-pascal@obry.net","subject":"Re: [PATCH] Set OLD_ICONV on Cygwin.","fromName":"Pascal Obry","fromEmail":"pascal@obry.net","sentAt":"2007-12-03T18:49:43Z","receivedAt":"2007-12-03T18:49:43Z","isPatch":true,"sender":{"key":"pascal@obry.net","avatar":"https://avatars.githubusercontent.com/u/467069?v=4"},"body":"\nI pretty well understand that this patch is not very important but since\nI got no reply I'm wondering if there is something wrong with it ?\n\nPascal.\n\n-- \n\n--|------------------------------------------------------\n--| Pascal Obry                           Team-Ada Member\n--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE\n--|------------------------------------------------------\n--|              http://www.obry.net\n--| \"The best way to travel is by means of imagination\"\n--|\n--| gpg --keyserver wwwkeys.pgp.net --recv-key C1082595\n"},{"id":"61893","messageId":"47551EBB.8030504@op5.se","threadId":"11074","inReplyTo":"47544FC7.3070100@obry.net","subject":"Re: [PATCH] Set OLD_ICONV on Cygwin.","fromName":"Andreas Ericsson","fromEmail":"ae@op5.se","sentAt":"2007-12-04T09:32:43Z","receivedAt":"2007-12-04T09:32:43Z","isPatch":true,"sender":{"key":"ae@op5.se","avatar":"https://gravatar.com/avatar/426e89595c75a8f5252dd0c989e5fabe5bcac616e68557427ad9aef6b0ca342a?d=mp&s=160"},"body":"Pascal Obry wrote:\n> I pretty well understand that this patch is not very important but since\n> I got no reply I'm wondering if there is something wrong with it ?\n> \n\nOnly one, insofar as I can see; You didn't CC Junio. He probably missed it.\n\n-- \nAndreas Ericsson                   andreas.ericsson@op5.se\nOP5 AB                             www.op5.se\nTel: +46 8-230225                  Fax: +46 8-230231\n"}]}