# [PATCH] Set OLD_ICONV on Cygwin.

3 messages from 2007-12-01 to 2007-12-04. Participants: Pascal Obry, Andreas Ericsson.
Thread: https://gitlist.dev/t/11074

## Pascal Obry, 2007-12-01 09:49

Subject: [PATCH] Set OLD_ICONV on Cygwin.
Message-ID: <1196502562-1052-1-git-send-email-pascal@obry.net>
URL: https://gitlist.dev/e/1196502562-1052-1-git-send-email-pascal%40obry.net

```
Cygwin still has old definition for the iconv() second
parameter. This patch fixes the last warning on Cygwin.
This has been tested with Cygwin 1.5.24.

Signed-off-by: Pascal Obry <pascal@obry.net>
---
 Makefile |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/Makefile b/Makefile
index e869b85..fa3398c 100644
--- a/Makefile
+++ b/Makefile
@@ -446,6 +446,7 @@ ifeq ($(uname_O),Cygwin)
 	NEEDS_LIBICONV = YesPlease
 	NO_FAST_WORKING_DIRECTORY = UnfortunatelyYes
 	NO_TRUSTABLE_FILEMODE = UnfortunatelyYes
+	OLD_ICONV = UnfortunatelyYes
 	# There are conflicting reports about this.
 	# On some boxes NO_MMAP is needed, and not so elsewhere.
 	# Try commenting this out if you suspect MMAP is more efficient
-- 
1.5.3.6.985.g65c6a4

```

## Pascal Obry, 2007-12-03 18:49

Subject: Re: [PATCH] Set OLD_ICONV on Cygwin.
Message-ID: <47544FC7.3070100@obry.net>
URL: https://gitlist.dev/e/47544FC7.3070100%40obry.net
In-Reply-To: <1196502562-1052-1-git-send-email-pascal@obry.net>

```

I pretty well understand that this patch is not very important but since
I got no reply I'm wondering if there is something wrong with it ?

Pascal.

-- 

--|------------------------------------------------------
--| Pascal Obry                           Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--|              http://www.obry.net
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver wwwkeys.pgp.net --recv-key C1082595

```

## Andreas Ericsson, 2007-12-04 09:32

Subject: Re: [PATCH] Set OLD_ICONV on Cygwin.
Message-ID: <47551EBB.8030504@op5.se>
URL: https://gitlist.dev/e/47551EBB.8030504%40op5.se
In-Reply-To: <47544FC7.3070100@obry.net>

```
Pascal Obry wrote:
> I pretty well understand that this patch is not very important but since
> I got no reply I'm wondering if there is something wrong with it ?
> 

Only one, insofar as I can see; You didn't CC Junio. He probably missed it.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

```