threads / patch / 10560

patchgitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test

Subject: [PATCH] gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test

## tl;dr

3 messages between Nov 1, 2007 and Nov 1, 2007. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Jakub Narebski· Nov 1, 2007, 13:23 UTC · lore

It does appear to do nothing; gitweb is run as standalone program and not as CGI script in this test. This call caused problems later.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
 t/t9500-gitweb-standalone-no-errors.sh |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Show changes to t/t9500-gitweb-standalone-no-errors.sh +0 −1

diff --git a/t/t9500-gitweb-standalone-no-errors.sh b/t/t9500-gitweb-standalone-no-errors.sh
index f7bad5b..1bf0988 100755
--- a/t/t9500-gitweb-standalone-no-errors.sh
+++ b/t/t9500-gitweb-standalone-no-errors.sh
@@ -31,7 +31,6 @@ our \$projects_list = "";
 our \$export_ok = "";
 our \$strict_export = "";
 
-CGI::Carp::set_programname("gitweb/gitweb.cgi");
 EOF
 
 	cat >.git/description <<EOF

-- 
1.5.3.5

Junio C Hamano· Nov 1, 2007, 22:18 UTC · re: Jakub Narebski · lore

Re: [PATCH] gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test

Jakub Narebski <jnareb@gmail.com> writes:

> It does appear to do nothing; gitweb is run as standalone program
> and not as CGI script in this test.  This call caused problems later.

Care to describe "later problems" a bit more?

Show 20 quoted lines

>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
>  t/t9500-gitweb-standalone-no-errors.sh |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/t/t9500-gitweb-standalone-no-errors.sh b/t/t9500-gitweb-standalone-no-errors.sh
> index f7bad5b..1bf0988 100755
> --- a/t/t9500-gitweb-standalone-no-errors.sh
> +++ b/t/t9500-gitweb-standalone-no-errors.sh
> @@ -31,7 +31,6 @@ our \$projects_list = "";
>  our \$export_ok = "";
>  our \$strict_export = "";
>  
> -CGI::Carp::set_programname("gitweb/gitweb.cgi");
>  EOF
>  
>  	cat >.git/description <<EOF
> -- 
> 1.5.3.5

Jakub Narebski· Nov 1, 2007, 23:36 UTC · re: Junio C Hamano · lore

Re: [PATCH] gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test

Junio C Hamano wrote:

Show 6 quoted lines

> Jakub Narebski <jnareb@gmail.com> writes:
> 
>> It does appear to do nothing; gitweb is run as standalone program
>> and not as CGI script in this test.  This call caused problems later.
> 
> Care to describe "later problems" a bit more?

Sorry about that. The problems were while creating yet-to-be send
patch
  "gitweb: Add tests for overriding gitweb config with repo config"
Perhaps not in the current version. I forgot details.

Perhaps last sentence "This call caused problems later." should be simply removed from commit message.

-- 
Jakub Narebski
Poland