Re: [PATCH] gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 1, 2007, 22:18 UTC
Message-ID: <7vve8l8va0.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1193923396-17341-1-git-send-email-jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

> It does appear to do nothing; gitweb is run as standalone program
> and not as CGI script in this test.  This call caused problems later.

Care to describe "later problems" a bit more?

Show 20 quoted lines

>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
>  t/t9500-gitweb-standalone-no-errors.sh |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/t/t9500-gitweb-standalone-no-errors.sh b/t/t9500-gitweb-standalone-no-errors.sh
> index f7bad5b..1bf0988 100755
> --- a/t/t9500-gitweb-standalone-no-errors.sh
> +++ b/t/t9500-gitweb-standalone-no-errors.sh
> @@ -31,7 +31,6 @@ our \$projects_list = "";
>  our \$export_ok = "";
>  our \$strict_export = "";
>  
> -CGI::Carp::set_programname("gitweb/gitweb.cgi");
>  EOF
>  
>  	cat >.git/description <<EOF
> -- 
> 1.5.3.5