# [PATCH] gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test

3 messages from 2007-11-01 to 2007-11-01. Participants: Jakub Narebski, Junio C Hamano.
Thread: https://gitlist.dev/t/10560

## Jakub Narebski, 2007-11-01 13:23

Subject: [PATCH] gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test
Message-ID: <1193923396-17341-1-git-send-email-jnareb@gmail.com>
URL: https://gitlist.dev/e/1193923396-17341-1-git-send-email-jnareb%40gmail.com

```
It does appear to do nothing; gitweb is run as standalone program
and not as CGI script in this test.  This call caused problems later.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
 t/t9500-gitweb-standalone-no-errors.sh |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/t/t9500-gitweb-standalone-no-errors.sh b/t/t9500-gitweb-standalone-no-errors.sh
index f7bad5b..1bf0988 100755
--- a/t/t9500-gitweb-standalone-no-errors.sh
+++ b/t/t9500-gitweb-standalone-no-errors.sh
@@ -31,7 +31,6 @@ our \$projects_list = "";
 our \$export_ok = "";
 our \$strict_export = "";
 
-CGI::Carp::set_programname("gitweb/gitweb.cgi");
 EOF
 
 	cat >.git/description <<EOF
-- 
1.5.3.5

```

## Junio C Hamano, 2007-11-01 22:18

Subject: Re: [PATCH] gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test
Message-ID: <7vve8l8va0.fsf@gitster.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vve8l8va0.fsf%40gitster.siamese.dyndns.org
In-Reply-To: <1193923396-17341-1-git-send-email-jnareb@gmail.com>

```
Jakub Narebski <jnareb@gmail.com> writes:

> It does appear to do nothing; gitweb is run as standalone program
> and not as CGI script in this test.  This call caused problems later.

Care to describe "later problems" a bit more?

>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
>  t/t9500-gitweb-standalone-no-errors.sh |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/t/t9500-gitweb-standalone-no-errors.sh b/t/t9500-gitweb-standalone-no-errors.sh
> index f7bad5b..1bf0988 100755
> --- a/t/t9500-gitweb-standalone-no-errors.sh
> +++ b/t/t9500-gitweb-standalone-no-errors.sh
> @@ -31,7 +31,6 @@ our \$projects_list = "";
>  our \$export_ok = "";
>  our \$strict_export = "";
>  
> -CGI::Carp::set_programname("gitweb/gitweb.cgi");
>  EOF
>  
>  	cat >.git/description <<EOF
> -- 
> 1.5.3.5

```

## Jakub Narebski, 2007-11-01 23:36

Subject: Re: [PATCH] gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test
Message-ID: <200711020036.12715.jnareb@gmail.com>
URL: https://gitlist.dev/e/200711020036.12715.jnareb%40gmail.com
In-Reply-To: <7vve8l8va0.fsf@gitster.siamese.dyndns.org>

```
Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
> 
>> It does appear to do nothing; gitweb is run as standalone program
>> and not as CGI script in this test.  This call caused problems later.
> 
> Care to describe "later problems" a bit more?

Sorry about that. The problems were while creating yet-to-be send
patch
  "gitweb: Add tests for overriding gitweb config with repo config"
Perhaps not in the current version. I forgot details.

Perhaps last sentence "This call caused problems later." should be
simply removed from commit message.

-- 
Jakub Narebski
Poland

```