{"thread":{"id":"10560","subject":"[PATCH] gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test","startedAt":"2007-11-01T13:23:16Z","lastAt":"2007-11-01T23:36:11Z","messageCount":3,"participants":["Jakub Narebski","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"57820","messageId":"1193923396-17341-1-git-send-email-jnareb@gmail.com","threadId":"10560","inReplyTo":null,"subject":"[PATCH] gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-11-01T13:23:16Z","receivedAt":"2007-11-01T13:23:16Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"It does appear to do nothing; gitweb is run as standalone program\nand not as CGI script in this test.  This call caused problems later.\n\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\n t/t9500-gitweb-standalone-no-errors.sh |    1 -\n 1 files changed, 0 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t9500-gitweb-standalone-no-errors.sh b/t/t9500-gitweb-standalone-no-errors.sh\nindex f7bad5b..1bf0988 100755\n--- a/t/t9500-gitweb-standalone-no-errors.sh\n+++ b/t/t9500-gitweb-standalone-no-errors.sh\n@@ -31,7 +31,6 @@ our \\$projects_list = \"\";\n our \\$export_ok = \"\";\n our \\$strict_export = \"\";\n \n-CGI::Carp::set_programname(\"gitweb/gitweb.cgi\");\n EOF\n \n \tcat >.git/description <<EOF\n-- \n1.5.3.5\n"},{"id":"57886","messageId":"7vve8l8va0.fsf@gitster.siamese.dyndns.org","threadId":"10560","inReplyTo":"1193923396-17341-1-git-send-email-jnareb@gmail.com","subject":"Re: [PATCH] gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-11-01T22:18:15Z","receivedAt":"2007-11-01T22:18:15Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski <jnareb@gmail.com> writes:\n\n> It does appear to do nothing; gitweb is run as standalone program\n> and not as CGI script in this test.  This call caused problems later.\n\nCare to describe \"later problems\" a bit more?\n\n>\n> Signed-off-by: Jakub Narebski <jnareb@gmail.com>\n> ---\n>  t/t9500-gitweb-standalone-no-errors.sh |    1 -\n>  1 files changed, 0 insertions(+), 1 deletions(-)\n>\n> diff --git a/t/t9500-gitweb-standalone-no-errors.sh b/t/t9500-gitweb-standalone-no-errors.sh\n> index f7bad5b..1bf0988 100755\n> --- a/t/t9500-gitweb-standalone-no-errors.sh\n> +++ b/t/t9500-gitweb-standalone-no-errors.sh\n> @@ -31,7 +31,6 @@ our \\$projects_list = \"\";\n>  our \\$export_ok = \"\";\n>  our \\$strict_export = \"\";\n>  \n> -CGI::Carp::set_programname(\"gitweb/gitweb.cgi\");\n>  EOF\n>  \n>  \tcat >.git/description <<EOF\n> -- \n> 1.5.3.5\n"},{"id":"57898","messageId":"200711020036.12715.jnareb@gmail.com","threadId":"10560","inReplyTo":"7vve8l8va0.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-11-01T23:36:11Z","receivedAt":"2007-11-01T23:36:11Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Junio C Hamano wrote:\n> Jakub Narebski <jnareb@gmail.com> writes:\n> \n>> It does appear to do nothing; gitweb is run as standalone program\n>> and not as CGI script in this test.  This call caused problems later.\n> \n> Care to describe \"later problems\" a bit more?\n\nSorry about that. The problems were while creating yet-to-be send\npatch\n  \"gitweb: Add tests for overriding gitweb config with repo config\"\nPerhaps not in the current version. I forgot details.\n\nPerhaps last sentence \"This call caused problems later.\" should be\nsimply removed from commit message.\n\n-- \nJakub Narebski\nPoland\n"}]}