threads / patch / 10192

patchAdd missing = for comparison in obsolete actions check.

Subject: [TIG PATCH] Add missing = for comparison in obsolete actions check.

## tl;dr

2 messages between Oct 8, 2007 and Oct 9, 2007. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

James Bowes· Oct 8, 2007, 17:30 UTC · lore

Signed-off-by: James Bowes <jbowes@dangerouslyinc.com>
---
 tig.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to tig.c +1 −1

diff --git a/tig.c b/tig.c
index 933d083..30c505b 100644
--- a/tig.c
+++ b/tig.c
@@ -1184,7 +1184,7 @@ option_bind_command(int argc, char *argv[])
 	}
 
 	request = get_request(argv[2]);
-	if (request = REQ_NONE) {
+	if (request == REQ_NONE) {
 		const char *obsolete[] = { "cherry-pick" };
 		size_t namelen = strlen(argv[2]);
 		int i;

-- 
1.5.3.4.1155.gfe96ee

Jonas Fonseca· Oct 9, 2007, 00:53 UTC · re: James Bowes · lore

Re: [TIG PATCH] Add missing = for comparison in obsolete actions check.

James Bowes <jbowes@dangerouslyinc.com> wrote Mon, Oct 08, 2007:

Show 18 quoted lines

> Signed-off-by: James Bowes <jbowes@dangerouslyinc.com>
> ---
>  tig.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tig.c b/tig.c
> index 933d083..30c505b 100644
> --- a/tig.c
> +++ b/tig.c
> @@ -1184,7 +1184,7 @@ option_bind_command(int argc, char *argv[])
>  	}
>  
>  	request = get_request(argv[2]);
> -	if (request = REQ_NONE) {
> +	if (request == REQ_NONE) {
>  		const char *obsolete[] = { "cherry-pick" };
>  		size_t namelen = strlen(argv[2]);
>  		int i;

Oops, thanks. I should readd -Wall to CFLAGS in my config.make file.

-- 
Jonas Fonseca