git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [TIG PATCH] Add missing = for comparison in obsolete actions check.

From
Jonas Fonseca <fonseca@diku.dk>
Date
Oct 9, 2007, 00:53 UTC
Message-ID
<20071009005336.GA30818@diku.dk>
In-Reply-To
<20071008173034.GA27292@crux.toronto.redhat.com>
James Bowes <jbowes@dangerouslyinc.com> wrote Mon, Oct 08, 2007:
Show 18 quoted lines
> Signed-off-by: James Bowes <jbowes@dangerouslyinc.com>
> ---
>  tig.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tig.c b/tig.c
> index 933d083..30c505b 100644
> --- a/tig.c
> +++ b/tig.c
> @@ -1184,7 +1184,7 @@ option_bind_command(int argc, char *argv[])
>  	}
>  
>  	request = get_request(argv[2]);
> -	if (request = REQ_NONE) {
> +	if (request == REQ_NONE) {
>  		const char *obsolete[] = { "cherry-pick" };
>  		size_t namelen = strlen(argv[2]);
>  		int i;
Oops, thanks. I should readd -Wall to CFLAGS in my config.make file.
-- 
Jonas Fonseca
Previous: James Bowes
Message 2 of 2 in “Add missing = for comparison in obsolete actions check.”
  1. Add missing = for comparison in obsolete actions check.James Bowes, Oct 8, 2007
  2. Jonas FonsecaOct 9, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.