{"thread":{"id":"10192","subject":"[TIG PATCH] Add missing = for comparison in obsolete actions check.","startedAt":"2007-10-08T17:30:35Z","lastAt":"2007-10-09T00:53:36Z","messageCount":2,"participants":["James Bowes","Jonas Fonseca"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"55198","messageId":"20071008173034.GA27292@crux.toronto.redhat.com","threadId":"10192","inReplyTo":null,"subject":"[TIG PATCH] Add missing = for comparison in obsolete actions check.","fromName":"James Bowes","fromEmail":"jbowes@dangerouslyinc.com","sentAt":"2007-10-08T17:30:35Z","receivedAt":"2007-10-08T17:30:35Z","isPatch":true,"sender":{"key":"jbowes@dangerouslyinc.com","avatar":"https://gravatar.com/avatar/a2fe98c66b2b47a9fa9d2ba92ff949d54c3208b1f8acc2e745b4b84ae3c4483a?d=mp&s=160"},"body":"Signed-off-by: James Bowes <jbowes@dangerouslyinc.com>\n---\n tig.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/tig.c b/tig.c\nindex 933d083..30c505b 100644\n--- a/tig.c\n+++ b/tig.c\n@@ -1184,7 +1184,7 @@ option_bind_command(int argc, char *argv[])\n \t}\n \n \trequest = get_request(argv[2]);\n-\tif (request = REQ_NONE) {\n+\tif (request == REQ_NONE) {\n \t\tconst char *obsolete[] = { \"cherry-pick\" };\n \t\tsize_t namelen = strlen(argv[2]);\n \t\tint i;\n-- \n1.5.3.4.1155.gfe96ee\n"},{"id":"55216","messageId":"20071009005336.GA30818@diku.dk","threadId":"10192","inReplyTo":"20071008173034.GA27292@crux.toronto.redhat.com","subject":"Re: [TIG PATCH] Add missing = for comparison in obsolete actions check.","fromName":"Jonas Fonseca","fromEmail":"fonseca@diku.dk","sentAt":"2007-10-09T00:53:36Z","receivedAt":"2007-10-09T00:53:36Z","isPatch":true,"sender":{"key":"fonseca@diku.dk","avatar":"https://gravatar.com/avatar/f82f3ad698717c51873b020c750a92438c820a24056dc39fe4d07baa10a92264?d=mp&s=160"},"body":"James Bowes <jbowes@dangerouslyinc.com> wrote Mon, Oct 08, 2007:\n> Signed-off-by: James Bowes <jbowes@dangerouslyinc.com>\n> ---\n>  tig.c |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/tig.c b/tig.c\n> index 933d083..30c505b 100644\n> --- a/tig.c\n> +++ b/tig.c\n> @@ -1184,7 +1184,7 @@ option_bind_command(int argc, char *argv[])\n>  \t}\n>  \n>  \trequest = get_request(argv[2]);\n> -\tif (request = REQ_NONE) {\n> +\tif (request == REQ_NONE) {\n>  \t\tconst char *obsolete[] = { \"cherry-pick\" };\n>  \t\tsize_t namelen = strlen(argv[2]);\n>  \t\tint i;\n\nOops, thanks. I should readd -Wall to CFLAGS in my config.make file.\n\n-- \nJonas Fonseca\n"}]}