# [TIG PATCH] Add missing = for comparison in obsolete actions check. 2 messages from 2007-10-08 to 2007-10-09. Participants: James Bowes, Jonas Fonseca. Thread: https://gitlist.dev/t/10192 ## James Bowes, 2007-10-08 17:30 Subject: [TIG PATCH] Add missing = for comparison in obsolete actions check. Message-ID: <20071008173034.GA27292@crux.toronto.redhat.com> URL: https://gitlist.dev/e/20071008173034.GA27292%40crux.toronto.redhat.com ``` Signed-off-by: James Bowes --- tig.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tig.c b/tig.c index 933d083..30c505b 100644 --- a/tig.c +++ b/tig.c @@ -1184,7 +1184,7 @@ option_bind_command(int argc, char *argv[]) } request = get_request(argv[2]); - if (request = REQ_NONE) { + if (request == REQ_NONE) { const char *obsolete[] = { "cherry-pick" }; size_t namelen = strlen(argv[2]); int i; -- 1.5.3.4.1155.gfe96ee ``` ## Jonas Fonseca, 2007-10-09 00:53 Subject: Re: [TIG PATCH] Add missing = for comparison in obsolete actions check. Message-ID: <20071009005336.GA30818@diku.dk> URL: https://gitlist.dev/e/20071009005336.GA30818%40diku.dk In-Reply-To: <20071008173034.GA27292@crux.toronto.redhat.com> ``` James Bowes wrote Mon, Oct 08, 2007: > Signed-off-by: James Bowes > --- > tig.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tig.c b/tig.c > index 933d083..30c505b 100644 > --- a/tig.c > +++ b/tig.c > @@ -1184,7 +1184,7 @@ option_bind_command(int argc, char *argv[]) > } > > request = get_request(argv[2]); > - if (request = REQ_NONE) { > + if (request == REQ_NONE) { > const char *obsolete[] = { "cherry-pick" }; > size_t namelen = strlen(argv[2]); > int i; Oops, thanks. I should readd -Wall to CFLAGS in my config.make file. -- Jonas Fonseca ```