git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v9 2/8] t2400: print captured git output when finished

From
Jacob Abel <jacobabel@nullpo.dev>
Date
Apr 19, 2023, 13:36 UTC
Message-ID
<zyuwfbx5e57ly4ybfbnapbzbkw4ib5xbreu3nawkd4f5srhgfe@pwp4gw3hbgap>
In-Reply-To
<xmqqsfcxdu9k.fsf@gitster.g>
On 23/04/19 09:23AM, Jacob Abel wrote:
Show 24 quoted lines
> On 23/04/18 09:34AM, Junio C Hamano wrote:
> > [...]
>
> Ah ok I understand what you mean now.
>
> Would the following work? Since all we care about in `git worktree add` is
> `stderr`, can't we just duplicate `stderr` to `stdout` while redirecting
> stderr to `actual` so that in the event the git command fails, it's still
> displayed in the output of `sh t2400-*.sh -x`?
>
> diff --git a/t/t2400-worktree-add.sh b/t/t2400-worktree-add.sh
> index 82091cbb1f..a8f734b1c3 100755
> --- a/t/t2400-worktree-add.sh
> +++ b/t/t2400-worktree-add.sh
> @@ -327,8 +327,7 @@ test_expect_success 'add -B' '
>
>  test_expect_success 'add --quiet' '
>  	test_when_finished "git worktree remove -f -f another-worktree" &&
> -	test_when_finished "cat actual" &&
> -	git worktree add --quiet another-worktree main 2>actual &&
> +	git worktree add --quiet another-worktree main 2>actual 2>&1 &&
>  	test_must_be_empty actual
>  '
>

Ok scratch that. I tried checking this a bit more and it doesn't work quite as expected. I'll remove the `cat actual`s from the tests and if I can think of a better alternative, I'll report back.

Previous: Jacob AbelNext: Junio C Hamano
Message 8 of 34 in “worktree: Support `--orphan` when creating new worktrees”
  1. 0/8 worktree: Support `--orphan` when creating new worktreesJacob Abel, Apr 17, 2023
  2. 1/8 worktree add: include -B in usage docsJacob Abel, Apr 17, 2023
  3. 2/8 t2400: print captured git output when finishedJacob Abel, Apr 17, 2023
  4. Junio C HamanoApr 17, 2023
  5. Jacob AbelApr 18, 2023
  6. Junio C HamanoApr 18, 2023
  7. Jacob AbelApr 19, 2023
  8. Jacob AbelApr 19, 2023
  9. Junio C HamanoApr 19, 2023
  10. Jacob AbelApr 19, 2023
  11. 4/8 t2400: add tests to verify --quietJacob Abel, Apr 17, 2023
  12. Junio C HamanoApr 17, 2023
  13. Jacob AbelApr 20, 2023
  14. 5/8 worktree add: add --orphan flagJacob Abel, Apr 17, 2023
  15. 7/8 worktree add: extend DWIM to infer --orphanJacob Abel, Apr 17, 2023
  16. 3/8 t2400: refactor "worktree add" opt exclusion testsJacob Abel, Apr 17, 2023
  17. Junio C HamanoApr 17, 2023
  18. Jacob AbelApr 20, 2023
  19. 6/8 worktree add: introduce "try --orphan" hintJacob Abel, Apr 17, 2023
  20. 8/8 worktree add: emit warn when there is a bad HEADJacob Abel, Apr 17, 2023
  21. Jacob AbelApr 20, 2023
  22. Junio C HamanoMay 1, 2023
  23. Jacob AbelMay 2, 2023
  24. 0/8 worktree: Support `--orphan` when creating new worktreesJacob Abel, May 17, 2023
  25. 1/8 worktree add: include -B in usage docsJacob Abel, May 17, 2023
  26. 2/8 t2400: cleanup created worktree in testJacob Abel, May 17, 2023
  27. 3/8 t2400: refactor "worktree add" opt exclusion testsJacob Abel, May 17, 2023
  28. 4/8 t2400: add tests to verify --quietJacob Abel, May 17, 2023
  29. 6/8 worktree add: introduce "try --orphan" hintJacob Abel, May 17, 2023
  30. 5/8 worktree add: add --orphan flagJacob Abel, May 17, 2023
  31. 7/8 worktree add: extend DWIM to infer --orphanJacob Abel, May 17, 2023
  32. RESEND [PATCH v10 7/8] worktree add: extend DWIM to infer --orphanTeng Long, Aug 9, 2023
  33. Jacob AbelAug 11, 2023
  34. 8/8 worktree add: emit warn when there is a bad HEADJacob Abel, May 17, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.