git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rev-parse: fix --resolve-git-dir argument handling

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 19, 2014, 00:25 UTC
Message-ID
<xmqqzjlo9ce6.fsf@gitster.dls.corp.google.com>
In-Reply-To
<xmqq61ocdug5.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 15 quoted lines
> John Keeping <john@keeping.me.uk> writes:
>
>> There are two problems here:
>>
>> 1) If no argument is provided, then the command segfaults
>> 2) The argument is not consumed, so there will be excess output
>>
>> Fix both of these in one go by restructuring the handler for this
>> option.
>>
>> Reported-by: Daniel Hahler <genml+git-2014@thequod.de>
>> Signed-off-by: John Keeping <john@keeping.me.uk>
>> ---
>
> Looks sensible; thanks.

Ehh, I spoke too fast. Don't we already have this queued as a43219f2 (rev-parse: check i before using argv[i] against argc, 2014-01-28)?

Previous: Junio C HamanoNext: John Keeping
Message 4 of 5 in “Output from "rev-parse --resolve-git-dir" changed: two lines (prints original argument)”
  1. Daniel HahlerFeb 17, 2014
  2. rev-parse: fix --resolve-git-dir argument handlingJohn Keeping, Feb 17, 2014
  3. Junio C HamanoFeb 18, 2014
  4. Junio C HamanoFeb 19, 2014
  5. John KeepingFeb 19, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.