Re: [PATCH] rev-parse: fix --resolve-git-dir argument handling

From: John Keeping <john@keeping.me.uk>
Date: Feb 19, 2014, 09:09 UTC
Message-ID: <20140219090948.GD1048@serenity.lan>
In-Reply-To: <xmqqzjlo9ce6.fsf@gitster.dls.corp.google.com>

On Tue, Feb 18, 2014 at 04:25:37PM -0800, Junio C Hamano wrote:

Show 20 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
> > John Keeping <john@keeping.me.uk> writes:
> >
> >> There are two problems here:
> >>
> >> 1) If no argument is provided, then the command segfaults
> >> 2) The argument is not consumed, so there will be excess output
> >>
> >> Fix both of these in one go by restructuring the handler for this
> >> option.
> >>
> >> Reported-by: Daniel Hahler <genml+git-2014@thequod.de>
> >> Signed-off-by: John Keeping <john@keeping.me.uk>
> >> ---
> >
> > Looks sensible; thanks.
> 
> Ehh, I spoke too fast. Don't we already have this queued as a43219f2
> (rev-parse: check i before using argv[i] against argc, 2014-01-28)?

Yes, and it catches more cases than mine. I only checked against master and had missed that when it went past on the list.