From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 19 Feb 2014 00:25:37 GMT
Subject: Re: [PATCH] rev-parse: fix --resolve-git-dir argument handling
Message-ID: <xmqqzjlo9ce6.fsf@gitster.dls.corp.google.com>
In-Reply-To: <xmqq61ocdug5.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

> John Keeping <john@keeping.me.uk> writes:
>
>> There are two problems here:
>>
>> 1) If no argument is provided, then the command segfaults
>> 2) The argument is not consumed, so there will be excess output
>>
>> Fix both of these in one go by restructuring the handler for this
>> option.
>>
>> Reported-by: Daniel Hahler <genml+git-2014@thequod.de>
>> Signed-off-by: John Keeping <john@keeping.me.uk>
>> ---
>
> Looks sensible; thanks.

Ehh, I spoke too fast. Don't we already have this queued as a43219f2
(rev-parse: check i before using argv[i] against argc, 2014-01-28)?