git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] format-patch --signature-file <file>

From
Junio C Hamano <gitster@pobox.com>
Date
May 20, 2014, 15:06 UTC
Message-ID
<xmqqzjic1oc5.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20140520062132.GA5222@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 12 quoted lines
> You could do:
>
>   #define DEFAULT_SIGNATURE git_version_string
>   static const char *signature = DEFAULT_SIGNATURE;
>
>   ...
>
>   if (signature == DEFAULT_SIGNATURE)
>      ...
>
> but maybe that is getting a little unwieldy, considering the scope of
> the original problem.
I agree.  It is an invitation for doing something like
	#define DEFAULT_SIGNATURE "-- \nfoo bar\n"
which defeats the purpose.

I have an unrelated and larger design level suggestion, but it may be better for me to refrain from sending it during the -rc freeze.

Previous: Jeff KingNext: Jeremiah Mahler
Message 12 of 13 in “format-patch --signature-file <file>”
  1. format-patch --signature-file <file>Jeremiah Mahler, May 16, 2014
  2. format-patch --signature-file <file>Jeremiah Mahler, May 16, 2014
  3. Jeff KingMay 16, 2014
  4. Jeremiah MahlerMay 17, 2014
  5. Jeff KingMay 17, 2014
  6. Jeremiah MahlerMay 17, 2014
  7. Jeff KingMay 17, 2014
  8. Jeremiah MahlerMay 17, 2014
  9. Junio C HamanoMay 19, 2014
  10. Jeremiah MahlerMay 20, 2014
  11. Jeff KingMay 20, 2014
  12. Junio C HamanoMay 20, 2014
  13. Jeremiah MahlerMay 21, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.