Re: [PATCH v2] format-patch --signature-file <file>

From: Jeremiah Mahler <jmmahler@gmail.com>
Date: May 21, 2014, 00:45 UTC
Message-ID: <20140521004559.GB4927@hudson.localdomain>
In-Reply-To: <xmqqzjic1oc5.fsf@gitster.dls.corp.google.com>

On Tue, May 20, 2014 at 08:06:50AM -0700, Junio C Hamano wrote:

Show 23 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > You could do:
> >
> >   #define DEFAULT_SIGNATURE git_version_string
> >   static const char *signature = DEFAULT_SIGNATURE;
> >
> >   ...
> >
> >   if (signature == DEFAULT_SIGNATURE)
> >      ...
> >
> > but maybe that is getting a little unwieldy, considering the scope of
> > the original problem.
> 
> I agree.  It is an invitation for doing something like
> 
> 	#define DEFAULT_SIGNATURE "-- \nfoo bar\n"
> 
> which defeats the purpose.
> 
> I have an unrelated and larger design level suggestion, but it may
> be better for me to refrain from sending it during the -rc freeze.

I will take DEFAULT_SIGNATURE out of the next patch revision.

-- 
Jeremiah Mahler
jmmahler@gmail.com
http://github.com/jmahler