Re: [PATCH v2] format-patch --signature-file <file>

From: Jeremiah Mahler <jmmahler@gmail.com>
Date: May 20, 2014, 05:46 UTC
Message-ID: <20140520054621.GA28317@hudson.localdomain>
In-Reply-To: <xmqqd2f93e0m.fsf@gitster.dls.corp.google.com>

On Mon, May 19, 2014 at 09:54:33AM -0700, Junio C Hamano wrote:

Show 13 quoted lines

> Jeremiah Mahler <jmmahler@gmail.com> writes:
> 
> > On Sat, May 17, 2014 at 06:00:14AM -0400, Jeff King wrote:
> >> 
>
> Avoiding that is easy with an indirection, no?  Something like this
> at the top:
> 
>   static const char *the_default_signature = git_version_string;
>   static const char *signature = the_default_signature;
> 
> and comparing to see if signature points at the same address as
> the_default_signature would give you what you want, I think.

I like your suggestion for a default signature variable. Unfortunately, C doesn't like it as much.

static const char *the_default_signature = git_version_string; static const char *signature = the_default_signature; // ERROR // initializer element is not constant

-- 
Jeremiah Mahler
jmmahler@gmail.com
http://github.com/jmahler