git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/5] pack-objects: walk tag chains for --include-tag

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 7, 2016, 18:49 UTC
Message-ID
<xmqqzinjlf47.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20160905215939.hriu6ev3m332qhp6@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 7 quoted lines
> As explained further in the commit message, "fetch" is robust to this,
> because it does a real connectivity check and follow-on fetch before
> writing anything it thinks it got via include-tag. So perhaps one could
> argue that pack-objects is correct; include-tag is best-effort, and it
> is the client's job to make sure it has everything it needs. And that
> would mean the bug is in git-clone, which should be doing the
> connectivity check and follow-on fetch.

I think that is probably a more technically correct interpretation of the history.

I think upgrading "best-effort" to "guarantee" like you did is a right approach nevertheless. I think the "best-effort" we initially did was merely us being lazy.

Previous: Jeff KingNext: Jeff King
Message 8 of 10 in “handle tag recursion in pack-objects --include-tag”
  1. 0/5 handle tag recursion in pack-objects --include-tagJeff King, Sep 5, 2016
  2. 1/5 t5305: move cleanup into test blockJeff King, Sep 5, 2016
  3. 2/5 t5305: drop "dry-run" of unpack-objectsJeff King, Sep 5, 2016
  4. 3/5 t5305: use "git -C"Jeff King, Sep 5, 2016
  5. 4/5 t5305: simplify packname handlingJeff King, Sep 5, 2016
  6. 5/5 pack-objects: walk tag chains for --include-tagJeff King, Sep 5, 2016
  7. Jeff KingSep 5, 2016
  8. Junio C HamanoSep 7, 2016
  9. Jeff KingSep 7, 2016
  10. Jeff KingSep 5, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.