From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 07 Sep 2016 18:49:28 GMT
Subject: Re: [PATCH 5/5] pack-objects: walk tag chains for --include-tag
Message-ID: <xmqqzinjlf47.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160905215939.hriu6ev3m332qhp6@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> As explained further in the commit message, "fetch" is robust to this,
> because it does a real connectivity check and follow-on fetch before
> writing anything it thinks it got via include-tag. So perhaps one could
> argue that pack-objects is correct; include-tag is best-effort, and it
> is the client's job to make sure it has everything it needs. And that
> would mean the bug is in git-clone, which should be doing the
> connectivity check and follow-on fetch.

I think that is probably a more technically correct interpretation
of the history.

I think upgrading "best-effort" to "guarantee" like you did is a
right approach nevertheless.  I think the "best-effort" we initially
did was merely us being lazy.