git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/5] t5305: drop "dry-run" of unpack-objects

From
Jeff King <peff@peff.net>
Date
Sep 5, 2016, 21:52 UTC
Message-ID
<20160905215213.apdmh7nubqxokcxw@sigill.intra.peff.net>
In-Reply-To
<20160905215141.b6unqtjqko7775is@sigill.intra.peff.net>

For each test we do a dry-run of unpack-objects, followed by a real run, followed by confirming that it contained the objects we expected. The dry-run is telling us nothing, as any errors it encounters would be found in the real run.

Signed-off-by: Jeff King <peff@peff.net>
---
 t/t5305-include-tag.sh | 2 --
 1 file changed, 2 deletions(-)
diff --git a/t/t5305-include-tag.sh b/t/t5305-include-tag.sh
index 6018404..787fc83 100755
--- a/t/t5305-include-tag.sh
+++ b/t/t5305-include-tag.sh
@@ -37,7 +37,6 @@ test_expect_success 'unpack objects' '
 		GIT_DIR=clone.git &&
 		export GIT_DIR &&
 		git init &&
-		git unpack-objects -n <test-1-${packname_1}.pack &&
 		git unpack-objects <test-1-${packname_1}.pack
 	)
 '
@@ -64,7 +63,6 @@ test_expect_success 'unpack objects' '
 		GIT_DIR=clone.git &&
 		export GIT_DIR &&
 		git init &&
-		git unpack-objects -n <test-2-${packname_1}.pack &&
 		git unpack-objects <test-2-${packname_1}.pack
 	)
 '
-- 
2.10.0.rc2.154.gb4a4b8b
Previous: Jeff KingNext: Jeff King
Message 3 of 10 in “handle tag recursion in pack-objects --include-tag”
  1. 0/5 handle tag recursion in pack-objects --include-tagJeff King, Sep 5, 2016
  2. 1/5 t5305: move cleanup into test blockJeff King, Sep 5, 2016
  3. 2/5 t5305: drop "dry-run" of unpack-objectsJeff King, Sep 5, 2016
  4. 3/5 t5305: use "git -C"Jeff King, Sep 5, 2016
  5. 4/5 t5305: simplify packname handlingJeff King, Sep 5, 2016
  6. 5/5 pack-objects: walk tag chains for --include-tagJeff King, Sep 5, 2016
  7. Jeff KingSep 5, 2016
  8. Junio C HamanoSep 7, 2016
  9. Jeff KingSep 7, 2016
  10. Jeff KingSep 5, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.