Re: [PATCH v6 4/6] builtin/tag: add --format argument for tag -v
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 18, 2017, 00:05 UTC
- Message-ID
- <xmqqziipb5cj.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20170117233723.23897-5-santiago@nyu.edu>
santiago@nyu.edu writes:
Show 10 quoted lines
> -static int for_each_tag_name(const char **argv, each_tag_name_fn fn)
> +static int for_each_tag_name(const char **argv, each_tag_name_fn fn,
> + void *cb_data)
> {
> const char **p;
> char ref[PATH_MAX];
> int had_error = 0;
> unsigned char sha1[20];
>
> +Why? I'll remove this while queuing.
> for (p = argv; *p; p++) {
> if (snprintf(ref, sizeof(ref), "refs/tags/%s", *p)
> >= sizeof(ref)) {