git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 4/6] builtin/tag: add --format argument for tag -v

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 18, 2017, 18:52 UTC
Message-ID
<xmqqo9z49p51.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20170118182831.pkhqu2np3bh2puei@LykOS.localdomain>
Santiago Torres <santiago@nyu.edu> writes:
Show 9 quoted lines
>> Squashing the following into this commit solves this issue with the
>> former approach.  The lines it touches are all from 4/6 and I view
>> all of it as general improvement, including type correctness and
>> code formatting.
>
> Thanks!
>
> Should I re-roll this really quick? Or would you rather apply this on
> your tree directly?

Nah, local squashing should be sufficient in this case. The squash only touches a single patch from the original and it itself is easy to review (and was reviewed already from what I can tell in this thread).

Previous: Eric WongNext: santiago@nyu.edu
Message 18 of 20 in “Add --format to tag verification”
  1. 0/6 Add --format to tag verificationsantiago@nyu.edu, Jan 17, 2017
  2. 6/6 t/t7004-tag: Add --format specifier testssantiago@nyu.edu, Jan 17, 2017
  3. 3/6 builtin/verify-tag: add --format to verify-tagsantiago@nyu.edu, Jan 17, 2017
  4. 1/6 gpg-interface,tag: add GPG_VERIFY_OMIT_STATUS flagsantiago@nyu.edu, Jan 17, 2017
  5. 2/6 ref-filter: add function to print single ref_array_itemsantiago@nyu.edu, Jan 17, 2017
  6. 4/6 builtin/tag: add --format argument for tag -vsantiago@nyu.edu, Jan 17, 2017
  7. Junio C HamanoJan 18, 2017
  8. Junio C HamanoJan 18, 2017
  9. Junio C HamanoJan 18, 2017
  10. Junio C HamanoJan 18, 2017
  11. Jeff KingJan 18, 2017
  12. Junio C HamanoJan 18, 2017
  13. Santiago TorresJan 18, 2017
  14. Junio C HamanoJan 18, 2017
  15. Santiago TorresJan 18, 2017
  16. Eric WongJan 18, 2017
  17. Eric WongJan 19, 2017
  18. Junio C HamanoJan 18, 2017
  19. 5/6 t/t7030-verify-tag: Add --format specifier testssantiago@nyu.edu, Jan 17, 2017
  20. Junio C HamanoJan 18, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.