git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v6 1/6] gpg-interface,tag: add GPG_VERIFY_OMIT_STATUS flag

From
santiago@nyu.edu <santiago@nyu.edu>
Date
Jan 17, 2017, 23:37 UTC
Message-ID
<20170117233723.23897-2-santiago@nyu.edu>
In-Reply-To
<20170117233723.23897-1-santiago@nyu.edu>
From: Lukas Puehringer <luk.puehringer@gmail.com>

Functions that print git object information may require that the gpg-interface functions be silent. Add GPG_VERIFY_OMIT_STATUS flag and prevent print_signature_buffer from being called if flag is set.

Signed-off-by: Lukas Puehringer <luk.puehringer@gmail.com>
---
 gpg-interface.h | 5 +++--
 tag.c           | 5 ++++-
 2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/gpg-interface.h b/gpg-interface.h
index ea68885ad..d2d4fd3a6 100644
--- a/gpg-interface.h
+++ b/gpg-interface.h
@@ -1,8 +1,9 @@
 #ifndef GPG_INTERFACE_H
 #define GPG_INTERFACE_H
 
-#define GPG_VERIFY_VERBOSE	1
-#define GPG_VERIFY_RAW		2
+#define GPG_VERIFY_VERBOSE		1
+#define GPG_VERIFY_RAW			2
+#define GPG_VERIFY_OMIT_STATUS	4
 
 struct signature_check {
 	char *payload;
diff --git a/tag.c b/tag.c
index d1dcd18cd..243d1fdbb 100644
--- a/tag.c
+++ b/tag.c
@@ -3,6 +3,7 @@
 #include "commit.h"
 #include "tree.h"
 #include "blob.h"
+#include "gpg-interface.h"
 
 const char *tag_type = "tag";
 
@@ -24,7 +25,9 @@ static int run_gpg_verify(const char *buf, unsigned long size, unsigned flags)
 
 	ret = check_signature(buf, payload_size, buf + payload_size,
 				size - payload_size, &sigc);
-	print_signature_buffer(&sigc, flags);
+
+	if (!(flags & GPG_VERIFY_OMIT_STATUS))
+		print_signature_buffer(&sigc, flags);
 
 	signature_check_clear(&sigc);
 	return ret;
-- 
2.11.0
Previous: santiago@nyu.eduNext: santiago@nyu.edu
Message 4 of 20 in “Add --format to tag verification”
  1. 0/6 Add --format to tag verificationsantiago@nyu.edu, Jan 17, 2017
  2. 6/6 t/t7004-tag: Add --format specifier testssantiago@nyu.edu, Jan 17, 2017
  3. 3/6 builtin/verify-tag: add --format to verify-tagsantiago@nyu.edu, Jan 17, 2017
  4. 1/6 gpg-interface,tag: add GPG_VERIFY_OMIT_STATUS flagsantiago@nyu.edu, Jan 17, 2017
  5. 2/6 ref-filter: add function to print single ref_array_itemsantiago@nyu.edu, Jan 17, 2017
  6. 4/6 builtin/tag: add --format argument for tag -vsantiago@nyu.edu, Jan 17, 2017
  7. Junio C HamanoJan 18, 2017
  8. Junio C HamanoJan 18, 2017
  9. Junio C HamanoJan 18, 2017
  10. Junio C HamanoJan 18, 2017
  11. Jeff KingJan 18, 2017
  12. Junio C HamanoJan 18, 2017
  13. Santiago TorresJan 18, 2017
  14. Junio C HamanoJan 18, 2017
  15. Santiago TorresJan 18, 2017
  16. Eric WongJan 18, 2017
  17. Eric WongJan 19, 2017
  18. Junio C HamanoJan 18, 2017
  19. 5/6 t/t7030-verify-tag: Add --format specifier testssantiago@nyu.edu, Jan 17, 2017
  20. Junio C HamanoJan 18, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.