git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 2/3] Makefile: add Perl runtime prefix support

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 8, 2018, 21:54 UTC
Message-ID
<xmqqzi5o6mp1.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<nycvar.QRO.7.76.6.1801082125210.31@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 32 quoted lines
> On Mon, 8 Jan 2018, Dan Jacques wrote:
>
>> On Mon, 08 Jan 2018, Ævar Arnfjörð Bjarmason replied:
>> 
>> >>+# it. This is intentionally separate from RUNTIME_PREFIX so that
>> >>notably Windows +# can hard-code Perl library paths while still
>> >>enabling RUNTIME_PREFIX +# resolution.
>> >
>> > Maybe we covered this in previous submissions, but refresh my memory,
>> > why is the *_PERL define still needed? Reading this explanation
>> > doesn't make sense to me, but I'm probably missing something.
>> >
>> > If we have a system where we have some perl library paths on the
>> > system we want to use, then they'll still be in @INC after our 'use
>> > lib'-ing, so we'll find libraries there.
>> >
>> > The only reason I can think of for doing this for C and not for Perl
>> > would be if you for some reason want to have a git in /tmp/git but
>> > then use a different version of the Git.pm from some system install,
>> > but I can't imagine why.
>> 
>> The reason is entirely due to the way Git-for-Windows is structured. In
>> Git-for-Windows, Git binaries are run directly from Windows, meaning
>> that they require RUNTIME_PREFIX resolution. However, Perl scripts are
>> run from a MinGW universe, within which filesystem paths are fixed.
>> Therefore, Windows Perl scripts don't require a runtime prefix
>> resolution.
>
> As I mentioned in the mail I just finished and sent (I started it hours
> ago, but then got busy with other things while the builds were running): I
> am totally cool with changing this on Windows, too. Should simplify
> things, right?

Wonderful to see that you two are in agreement. Will look forward to see a simplified solution in a later round ;-)

Previous: Johannes SchindelinNext: Dan Jacques
Message 8 of 13 in “RUNTIME_PREFIX relocatable Git”
  1. 0/3 RUNTIME_PREFIX relocatable GitDan Jacques, Jan 8, 2018
  2. 1/3 Makefile: generate Perl header from template fileDan Jacques, Jan 8, 2018
  3. 2/3 Makefile: add Perl runtime prefix supportDan Jacques, Jan 8, 2018
  4. Ævar Arnfjörð BjarmasonJan 8, 2018
  5. Dan JacquesJan 8, 2018
  6. Ævar Arnfjörð BjarmasonJan 8, 2018
  7. Johannes SchindelinJan 8, 2018
  8. Junio C HamanoJan 8, 2018
  9. Dan JacquesJan 8, 2018
  10. Ævar Arnfjörð BjarmasonJan 8, 2018
  11. Dan JacquesJan 8, 2018
  12. Johannes SchindelinJan 8, 2018
  13. 3/3 exec_cmd: RUNTIME_PREFIX on some POSIX systemsDan Jacques, Jan 8, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.