git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 2/3] Makefile: add Perl runtime prefix support

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 8, 2018, 20:24 UTC
Message-ID
<nycvar.QRO.7.76.6.1801081558580.31@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz>
In-Reply-To
<87inccbscj.fsf@evledraar.gmail.com>
Hi,
On Mon, 8 Jan 2018, Ævar Arnfjörð Bjarmason wrote:
Show 12 quoted lines
> 
> On Mon, Jan 08 2018, Dan Jacques jotted:
> 
> From 3/3 (not not send 2 e-mails):
> 
> >+# it. This is intentionally separate from RUNTIME_PREFIX so that notably Windows
> >+# can hard-code Perl library paths while still enabling RUNTIME_PREFIX
> >+# resolution.
> 
> Maybe we covered this in previous submissions, but refresh my memory,
> why is the *_PERL define still needed? Reading this explanation doesn't
> make sense to me, but I'm probably missing something.

If the reason is to accommodate Windows, I think it'd make more sense to change the way Git for Windows handles this, and use the same relative paths (if possible, that is, see the GITPERLLIB problems I mentioned elsewhere and which necessitated https://github.com/git-for-windows/git/commit/3b2f716bd8).

BTW I managed to run your `runtime-prefix` branch through VSTS builds on Windows, macOS and Linux and they all pass the test suite. (Including the RUNTIME_PREFIX_PERL=YesPlease setting you added for Travis CI testing.)

What do you think? Should we just fold the RUNTIME_PREFIX_PERL handling into RUNTIME_PREFIX and be done with that part?

Ciao, Johannes

Previous: Dan JacquesNext: Dan Jacques
Message 12 of 13 in “RUNTIME_PREFIX relocatable Git”
  1. 0/3 RUNTIME_PREFIX relocatable GitDan Jacques, Jan 8, 2018
  2. 1/3 Makefile: generate Perl header from template fileDan Jacques, Jan 8, 2018
  3. 2/3 Makefile: add Perl runtime prefix supportDan Jacques, Jan 8, 2018
  4. Ævar Arnfjörð BjarmasonJan 8, 2018
  5. Dan JacquesJan 8, 2018
  6. Ævar Arnfjörð BjarmasonJan 8, 2018
  7. Johannes SchindelinJan 8, 2018
  8. Junio C HamanoJan 8, 2018
  9. Dan JacquesJan 8, 2018
  10. Ævar Arnfjörð BjarmasonJan 8, 2018
  11. Dan JacquesJan 8, 2018
  12. Johannes SchindelinJan 8, 2018
  13. 3/3 exec_cmd: RUNTIME_PREFIX on some POSIX systemsDan Jacques, Jan 8, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.