git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 2/3] Makefile: add Perl runtime prefix support

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jan 8, 2018, 22:16 UTC
Message-ID
<877essatef.fsf@evledraar.gmail.com>
In-Reply-To
<20180108220550.66256-1-dnj@google.com>
On Mon, Jan 08 2018, Dan Jacques jotted:
Show 29 quoted lines
> On 2018-01-08 20:27, Johannes Schindelin wrote:
>
>> > Maybe we covered this in previous submissions, but refresh my memory,
>> > why is the *_PERL define still needed? Reading this explanation doesn't
>> > make sense to me, but I'm probably missing something.
>>
>> If the reason is to accommodate Windows, I think it'd make more sense to
>> change the way Git for Windows handles this, and use the same relative
>> paths (if possible, that is, see the GITPERLLIB problems I mentioned
>> elsewhere and which necessitated
>> https://github.com/git-for-windows/git/commit/3b2f716bd8).
>> (...)
>> What do you think? Should we just fold the RUNTIME_PREFIX_PERL handling
>> into RUNTIME_PREFIX and be done with that part?
>> (...)
>> As I mentioned in the mail I just finished and sent (I started it hours
>> ago, but then got busy with other things while the builds were running): I
>> am totally cool with changing this on Windows, too. Should simplify
>> things, right?
>
> No objections here. I see it as adding slightly more risk to this patch's
> potential impact on Windows builds, but if Git-for-Windows is okay with that,
> I'll go ahead and fold RUNTIME_PREFIX_PERL into RUNTIME_PREFIX for
> simplicity's sake.
>
> I'll add a "NO_RUNTIME_PREFIX_PERL" flag as per avarab@'s suggestion as a
> potential mitigation if a problem does end up arising in Windows builds,
> with a note that NO_RUNTIME_PREFIX_PERL can be deleted if everything seems
> to be working. What do you think?

To be clear, I meant that if it's determined by you/others that an opt-out on Windows is needed I think it makes sense to make it a NO_* flag, but if there's a solution where we can just turn it on for everything then ideally we'd just have RUNTIME_PREFIX=YesPlease.

Previous: Dan JacquesNext: Dan Jacques
Message 10 of 13 in “RUNTIME_PREFIX relocatable Git”
  1. 0/3 RUNTIME_PREFIX relocatable GitDan Jacques, Jan 8, 2018
  2. 1/3 Makefile: generate Perl header from template fileDan Jacques, Jan 8, 2018
  3. 2/3 Makefile: add Perl runtime prefix supportDan Jacques, Jan 8, 2018
  4. Ævar Arnfjörð BjarmasonJan 8, 2018
  5. Dan JacquesJan 8, 2018
  6. Ævar Arnfjörð BjarmasonJan 8, 2018
  7. Johannes SchindelinJan 8, 2018
  8. Junio C HamanoJan 8, 2018
  9. Dan JacquesJan 8, 2018
  10. Ævar Arnfjörð BjarmasonJan 8, 2018
  11. Dan JacquesJan 8, 2018
  12. Johannes SchindelinJan 8, 2018
  13. 3/3 exec_cmd: RUNTIME_PREFIX on some POSIX systemsDan Jacques, Jan 8, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.