Re: [PATCH 00/26] Moving global state into the repository object (part 1)
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 13, 2018, 19:35 UTC
- Message-ID
- <xmqqzi4cptsa.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <CAGZ79kZOq+_NOOabBUtPJ_zKNb_vdais70F6VzVFoSn5B5A4fQ@mail.gmail.com>
Stefan Beller <sbeller@google.com> writes:
Show 10 quoted lines
> For now the ignore_env bit lives in the repository, as that helps > when working with submodules, when reading its comments. > Unfortunately 359efeffc1 (repository: introduce the repository > object, 2017-06-22) did not reason about the existence of the ignore_env > flag in its commit message. > >> So from that point of view, it may not matter where the "bit" lives, >> among repository, object-store, or ref-store. > > It matters on the scale of confusing the developer?
What I meant is that from the point of view, having the bit in the data (not on the invocation) is confusing no matter which data structure holds it--they are equally bad.