Re: [PATCH 0/4] Delete ignore_env member in struct repository

From: Stefan Beller <sbeller@google.com>
Date: Feb 26, 2018, 20:46 UTC
Message-ID: <CAGZ79kbyrOc6zDSC4cirUW4ZLbDtEeOB=JwPrqxyye=wFR197Q@mail.gmail.com>
In-Reply-To: <20180226103030.26900-1-pclouds@gmail.com>

On Mon, Feb 26, 2018 at 2:30 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:

Show 18 quoted lines

> It turns out I don't need my other series [1] in order to delete this
> field. This series moves getenv() calls from
> repo_set_gitdir()/repo_setup_env() and prepare_alt_odb() back in
> environment.c where they belong in my opinion.
>
> The repo_set_gitdir() now takes $GIT_DIR and optionally all other
> configurable paths. If those paths are NULL, default repo layout will
> be used. With getenv() no longer called inside repo_set_gitdir(),
> ignore_env has no reason to stay. This is in 1/4.
>
> The getenv() in prepare_alt_odb() is also moved back to
> setup_git_env() in 3/4. It demonstrates how we could move other
> getenv() back to if we want.
>
> This series is built on top of Stefan's object-store-part1, v4. I
> could rebase it on 'master' too, but then Junio may need to resolve
> some conflicts.
>

Thanks for working on this, I found this series a pleasant read, the only issue I saw was Erics upbringing of multiple getenv calls without strdup()ing the content.

What is the plan from here on? Should I build further series on top of yours? The next series will focus on the pack side of things (pack.h, packfile.{c,h})

So maybe we'll have Junio merge down my series (and yours as it needs one reroll?) and then build on top of that?

Thanks, Stefan