git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 1/2] transport: warn if server options are unsupported

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 12, 2019, 05:35 UTC
Message-ID
<xmqqzhovyee7.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<63049081c98b8612bd233a6f01104c6196a09946.1555014408.git.jonathantanmy@google.com>
Jonathan Tan <jonathantanmy@google.com> writes:
> +test_expect_success 'warn if using server-option with ls-remote with legacy protocol' '
> +	GIT_TEST_PROTOCOL_VERSION=0 test_must_fail git -c protocol.version=0 \
> +		ls-remote -o hello -o world "file://$(pwd)/file_parent" master 2>err &&

test_must_fail is not an executable but is a shell function. Do not expect VAR=VAL in front of it to work as expected.

"make test" triggered test-lint that caught this.
Previous: Jonathan TanNext: Jonathan Tan
Message 14 of 22 in “clone: send server options when using protocol v2”
  1. clone: send server options when using protocol v2Jonathan Tan, Apr 5, 2019
  2. Jonathan NiederApr 6, 2019
  3. Jonathan TanApr 8, 2019
  4. Junio C HamanoApr 9, 2019
  5. Jonathan TanApr 9, 2019
  6. 0/2 Server options when cloningJonathan Tan, Apr 9, 2019
  7. 1/2 transport: warn if server options are unsupportedJonathan Tan, Apr 9, 2019
  8. Jonathan NiederApr 9, 2019
  9. Junio C HamanoApr 10, 2019
  10. 2/2 clone: send server options when using protocol v2Jonathan Tan, Apr 9, 2019
  11. Jonathan NiederApr 9, 2019
  12. 0/2 Server options when cloningJonathan Tan, Apr 11, 2019
  13. 1/2 transport: warn if server options are unsupportedJonathan Tan, Apr 11, 2019
  14. Junio C HamanoApr 12, 2019
  15. 2/2 clone: send server options when using protocol v2Jonathan Tan, Apr 11, 2019
  16. 0/2 Server options when cloningJonathan Tan, Apr 12, 2019
  17. 1/2 transport: die if server options are unsupportedJonathan Tan, Apr 12, 2019
  18. SZEDER GáborApr 12, 2019
  19. Re* [PATCH v4 1/2] transport: die if server options are unsupportedJunio C Hamano, Apr 15, 2019
  20. Junio C HamanoApr 15, 2019
  21. SZEDER GáborApr 15, 2019
  22. 2/2 clone: send server options when using protocol v2Jonathan Tan, Apr 12, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.