git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] clone: send server options when using protocol v2

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Apr 8, 2019, 17:11 UTC
Message-ID
<20190408171149.125872-1-jonathantanmy@google.com>
In-Reply-To
<20190406115728.GB219876@google.com>
Show 8 quoted lines
> > Teach "clone" the same ability, except that because "clone" already
> > has "-o" for another parameter, teach "clone" only to receive
> > "--server-option".
> 
> Can you give an example of what this would be used for?  An example I
> can think of might be
> 
> 	git clone --server-option=priority=batch <url>

protocol-v2.txt says that it is server-specific, so I don't think I can give any meaningful examples here.

Show 16 quoted lines
> > --- a/builtin/clone.c
> > +++ b/builtin/clone.c
> > @@ -66,6 +66,7 @@ static int option_dissociate;
> >  static int max_jobs = -1;
> >  static struct string_list option_recurse_submodules = STRING_LIST_INIT_NODUP;
> >  static struct list_objects_filter_options filter_options;
> > +static struct string_list server_options = STRING_LIST_INIT_DUP;
> 
> The other string-list options in this file all use NODUP.  Is there a
> reason this one uses DUP instead?  (Just curious --- I suspect either
> would work fine, since nothing here does tricks with modifying argv
> entries after option parsing.)
> 
> The same question applies to the corresponding option in
> builtin/fetch.c, so while it is not likely to matter in practice, it
> would be nice for readability to find out.

I guess it could be either. It's true that I just copied it from builtin/fetch.c. I'll change it to NODUP if a reroll is needed for another reason.

> > +	OPT_STRING_LIST(0, "server-option", &server_options, N_("server-specific"),
> 
> nit: long line
I'll change this if a reroll is needed for another reason.
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
> 
> Thanks for a pleasant read.
Thanks for your review.
Previous: Jonathan NiederNext: Junio C Hamano
Message 3 of 22 in “clone: send server options when using protocol v2”
  1. clone: send server options when using protocol v2Jonathan Tan, Apr 5, 2019
  2. Jonathan NiederApr 6, 2019
  3. Jonathan TanApr 8, 2019
  4. Junio C HamanoApr 9, 2019
  5. Jonathan TanApr 9, 2019
  6. 0/2 Server options when cloningJonathan Tan, Apr 9, 2019
  7. 1/2 transport: warn if server options are unsupportedJonathan Tan, Apr 9, 2019
  8. Jonathan NiederApr 9, 2019
  9. Junio C HamanoApr 10, 2019
  10. 2/2 clone: send server options when using protocol v2Jonathan Tan, Apr 9, 2019
  11. Jonathan NiederApr 9, 2019
  12. 0/2 Server options when cloningJonathan Tan, Apr 11, 2019
  13. 1/2 transport: warn if server options are unsupportedJonathan Tan, Apr 11, 2019
  14. Junio C HamanoApr 12, 2019
  15. 2/2 clone: send server options when using protocol v2Jonathan Tan, Apr 11, 2019
  16. 0/2 Server options when cloningJonathan Tan, Apr 12, 2019
  17. 1/2 transport: die if server options are unsupportedJonathan Tan, Apr 12, 2019
  18. SZEDER GáborApr 12, 2019
  19. Re* [PATCH v4 1/2] transport: die if server options are unsupportedJunio C Hamano, Apr 15, 2019
  20. Junio C HamanoApr 15, 2019
  21. SZEDER GáborApr 15, 2019
  22. 2/2 clone: send server options when using protocol v2Jonathan Tan, Apr 12, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.