Re: [PATCH v2 1/2] transport: warn if server options are unsupported

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 10, 2019, 03:51 UTC
Message-ID: <xmqq4l7634d6.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190409204525.GA92879@google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 5 quoted lines

> Thanks for writing this.  I'd be in favor of making this die().
> Compare what we already do in push:
>
> 	if (args->push_options && !push_options_supported)
> 		die(_("the receiving end does not support push options"));

That's a good point.

> What happens in the case of push with protocol v0, where server options
> are supported?

Are, or are not?

In any case, all other suggestions in your reviews are worth following up, I would think. Thanks for a quick review.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.