Re: [PATCH v2] Propagate --quiet on submodule update to merge/rebase

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 30, 2020, 20:58 UTC
Message-ID: <xmqqzh57f0dh.fsf@gitster.c.googlers.com>
In-Reply-To: <20200930195052.118199-1-tbodt@google.com>

Theodore Dubois <tbodt@google.com> writes:

Show 7 quoted lines

> Without this, commands such as
> git pull --rebase --recurse-submodules --quiet
> might produce non-quiet output from the merge or rebase.
>
> Also fix the parsing of git submodule update -v. Setting GIT_QUIET to 0
> has the same effect as setting GIT_QUIET to 1, because
> ${GIT_QUIET:+--quiet} only checks whether GIT_QUIET is set or unset.

Thanks.

Will queue with the following log message.

    submodule update: silence underlying merge/rebase "--quiet" is given
    
    Commands such as
    
        $ git pull --rebase --recurse-submodules --quiet
    
    produce non-quiet output from the merge or rebase.  Pass the --quiet
    option down when invoking "rebase" and "merge".
    
    Also fix the parsing of git submodule update -v.
    
    When e84c3cf3 (git-submodule.sh: accept verbose flag in cmd_update
    to be non-quiet, 2018-08-14) taught "git submodule update" to take
    "--quiet", it apparently did not know how ${GIT_QUIET:+--quiet}
    works, and reviewers seem to have missed that setting the variable
    to "0" (instead of "1" which is used when "--quiet" is given) has
    the same effect to pass "--quiet" to underlying commands.
    
    Signed-off-by: Theodore Dubois <tbodt@google.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>