Re: [PATCH v2] Propagate --quiet on submodule update to merge/rebase

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Oct 1, 2020, 05:38 UTC
Message-ID: <20201001053803.GC2930867@google.com>
In-Reply-To: <xmqqzh57f0dh.fsf@gitster.c.googlers.com>

Junio C Hamano wrote:

> Theodore Dubois <tbodt@google.com> writes:

Show 13 quoted lines

>> Without this, commands such as
>> git pull --rebase --recurse-submodules --quiet
>> might produce non-quiet output from the merge or rebase.
>>
>> Also fix the parsing of git submodule update -v. Setting GIT_QUIET to 0
>> has the same effect as setting GIT_QUIET to 1, because
>> ${GIT_QUIET:+--quiet} only checks whether GIT_QUIET is set or unset.
>
> Thanks.
>
> Will queue with the following log message.
>
>     submodule update: silence underlying merge/rebase "--quiet" is given

Missing 'when' before '"--quiet"', as Eric noticed.

Aside from that,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks, all.