Re: [PATCH v2] Propagate --quiet on submodule update to merge/rebase
On Wed, Sep 30, 2020 at 4:58 PM Junio C Hamano <gitster@pobox.com> wrote:
> Will queue with the following log message.
>
> submodule update: silence underlying merge/rebase "--quiet" is given
Probably want to insert "when" in there.
Show 15 quoted lines
> Commands such as
>
> $ git pull --rebase --recurse-submodules --quiet
>
> produce non-quiet output from the merge or rebase. Pass the --quiet
> option down when invoking "rebase" and "merge".
>
> Also fix the parsing of git submodule update -v.
>
> When e84c3cf3 (git-submodule.sh: accept verbose flag in cmd_update
> to be non-quiet, 2018-08-14) taught "git submodule update" to take
> "--quiet", it apparently did not know how ${GIT_QUIET:+--quiet}
> works, and reviewers seem to have missed that setting the variable
> to "0" (instead of "1" which is used when "--quiet" is given) has
> the same effect to pass "--quiet" to underlying commands.Perhaps:
... to "0", rather than unsetting it, still results in "--quiet"
being passed to underlying commands.Eric Sunshine <sunshine@sunshineco.com>