Re: [PATCH v2 0/4] update-ref: Allow creation of multiple transactions

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 9, 2020, 22:38 UTC
Message-ID: <xmqqzh3q9mvf.fsf@gitster.c.googlers.com>
In-Reply-To: <20201109223330.GC670413@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 21 quoted lines

> On Mon, Nov 09, 2020 at 11:06:43AM +0100, Patrick Steinhardt wrote:
>
>> this is the second version of this patch series implementing support for
>> creation of multiple reference transactions in a single git-update-ref
>> process.
>> 
>> There's two changes compared to v1:
>> 
>>     - A small refactoring of t1400, which refactors many tests to not
>>       touch references via the filesystem but instead to use
>>       git-update-ref and git-show-ref. There's still tests in there
>>       which do, but converting them is harder as they create and read
>>       broken references.
>> 
>>     - I've added another commit on top which disallows restarting of
>>       transactions. E.g. writing "start\nstart\n" to git-update-ref is
>>       now going to fail.
>
> Thanks. Aside from the issues raised by Junio, this all looks good to me
> (and I agree on the fourth one it is just a matter of the commit
> message; what the code is doing is a definite improvement).

Yeah, I agree that it is just terminology. If we were to explain it as lack of nested transaction, however, the error message would need to be updated. Other than that, I think this is quite good.

Oh, Patrick, please do not forget that it is our convention not to Capitalize the word immediately after <area>: on the title of the commit (cf. "git shortlog --no-merges -200").

Thanks.