git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/4] update-ref: Allow creation of multiple transactions

From
Jeff King <peff@peff.net>
Date
Nov 9, 2020, 22:33 UTC
Message-ID
<20201109223330.GC670413@coredump.intra.peff.net>
In-Reply-To
<cover.1604908834.git.ps@pks.im>
On Mon, Nov 09, 2020 at 11:06:43AM +0100, Patrick Steinhardt wrote:
Show 15 quoted lines
> this is the second version of this patch series implementing support for
> creation of multiple reference transactions in a single git-update-ref
> process.
> 
> There's two changes compared to v1:
> 
>     - A small refactoring of t1400, which refactors many tests to not
>       touch references via the filesystem but instead to use
>       git-update-ref and git-show-ref. There's still tests in there
>       which do, but converting them is harder as they create and read
>       broken references.
> 
>     - I've added another commit on top which disallows restarting of
>       transactions. E.g. writing "start\nstart\n" to git-update-ref is
>       now going to fail.

Thanks. Aside from the issues raised by Junio, this all looks good to me (and I agree on the fourth one it is just a matter of the commit message; what the code is doing is a definite improvement).

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 20 of 41 in “update-ref: Allow creation of multiple transactions”
  1. 0/2 update-ref: Allow creation of multiple transactionsPatrick Steinhardt, Nov 4, 2020
  2. 1/2 update-ref: Allow creation of multiple transactionsPatrick Steinhardt, Nov 4, 2020
  3. Jeff KingNov 5, 2020
  4. Junio C HamanoNov 5, 2020
  5. Jeff KingNov 6, 2020
  6. Junio C HamanoNov 6, 2020
  7. Patrick SteinhardtNov 6, 2020
  8. 2/2 p1400: Use `git-update-ref --stdin` to test multiple transactionsPatrick Steinhardt, Nov 4, 2020
  9. Jeff KingNov 5, 2020
  10. 0/4 update-ref: Allow creation of multiple transactionsPatrick Steinhardt, Nov 9, 2020
  11. 1/4 t1400: Avoid touching refs on filesystemPatrick Steinhardt, Nov 9, 2020
  12. Junio C HamanoNov 9, 2020
  13. Jeff KingNov 9, 2020
  14. Patrick SteinhardtNov 10, 2020
  15. Junio C HamanoNov 10, 2020
  16. 2/4 update-ref: Allow creation of multiple transactionsPatrick Steinhardt, Nov 9, 2020
  17. 3/4 p1400: Use `git-update-ref --stdin` to test multiple transactionsPatrick Steinhardt, Nov 9, 2020
  18. 4/4 update-ref: Disallow restart of ongoing transactionsPatrick Steinhardt, Nov 9, 2020
  19. Junio C HamanoNov 9, 2020
  20. Jeff KingNov 9, 2020
  21. Junio C HamanoNov 9, 2020
  22. 0/4 update-ref: allow creation of multiple transactionsPatrick Steinhardt, Nov 11, 2020
  23. 1/4 t1400: avoid touching refs on filesystemPatrick Steinhardt, Nov 11, 2020
  24. SZEDER GáborNov 11, 2020
  25. Patrick SteinhardtNov 11, 2020
  26. SZEDER GáborNov 11, 2020
  27. Jeff KingNov 11, 2020
  28. Patrick SteinhardtNov 13, 2020
  29. 2/4 update-ref: allow creation of multiple transactionsPatrick Steinhardt, Nov 11, 2020
  30. 3/4 p1400: use `git-update-ref --stdin` to test multiple transactionsPatrick Steinhardt, Nov 11, 2020
  31. 4/4 update-ref: disallow "start" for ongoing transactionsPatrick Steinhardt, Nov 11, 2020
  32. 0/4 update-ref: allow creation of multiple transactionsPatrick Steinhardt, Nov 13, 2020
  33. 1/4 t1400: avoid touching refs on filesystemPatrick Steinhardt, Nov 13, 2020
  34. Jeff KingNov 13, 2020
  35. Patrick SteinhardtNov 18, 2020
  36. Junio C HamanoNov 18, 2020
  37. 2/4 update-ref: allow creation of multiple transactionsPatrick Steinhardt, Nov 13, 2020
  38. 3/4 p1400: use `git-update-ref --stdin` to test multiple transactionsPatrick Steinhardt, Nov 13, 2020
  39. 4/4 update-ref: disallow "start" for ongoing transactionsPatrick Steinhardt, Nov 13, 2020
  40. Junio C HamanoNov 25, 2020
  41. Jeff KingNov 26, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.