git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/4] t1400: Avoid touching refs on filesystem

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 10, 2020, 17:04 UTC
Message-ID
<xmqq7dqt87pa.fsf@gitster.c.googlers.com>
In-Reply-To
<X6qIidgbnhYa3S0o@ncase>
Patrick Steinhardt <ps@pks.im> writes:
Show 20 quoted lines
>> For now, I think this is fine, but we'd probably clean it up so that
>> without --force update-ref would not corrupt the repository like
>> this.  When used with --force, or before adding such a safety
>> measure, how we test if we successfully corrupted the repository is
>> an interesting matter.  I'd say
>> 
>> 	git update-ref --force --no-deref -d HEAD &&
>> 	test_must_fail git show-ref --verify -q HEAD &&
>> 	cp -f .git/HEAD.orig .git/HEAD &&
>> 	git show-ref --verify -q "$m"
>> 
>> to ensure that other than removing HEAD and corrupting the
>> repository, it did not cause permanent damage by removing the
>> underlying ref, perhaps.
>> 
>> We may want to add some NEEDSWORK comment around such tests.
>
> I think the proper way to do the test would be to create a non-mandatory
> symref and delete it. That'd also be a nice preparation for the
> `--force` parameter already.

Excellent. Yes, the test is about creation and removal of a symref; the symref used for testing does not have to be the HEAD.

Thanks.
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 15 of 41 in “update-ref: Allow creation of multiple transactions”
  1. 0/2 update-ref: Allow creation of multiple transactionsPatrick Steinhardt, Nov 4, 2020
  2. 1/2 update-ref: Allow creation of multiple transactionsPatrick Steinhardt, Nov 4, 2020
  3. Jeff KingNov 5, 2020
  4. Junio C HamanoNov 5, 2020
  5. Jeff KingNov 6, 2020
  6. Junio C HamanoNov 6, 2020
  7. Patrick SteinhardtNov 6, 2020
  8. 2/2 p1400: Use `git-update-ref --stdin` to test multiple transactionsPatrick Steinhardt, Nov 4, 2020
  9. Jeff KingNov 5, 2020
  10. 0/4 update-ref: Allow creation of multiple transactionsPatrick Steinhardt, Nov 9, 2020
  11. 1/4 t1400: Avoid touching refs on filesystemPatrick Steinhardt, Nov 9, 2020
  12. Junio C HamanoNov 9, 2020
  13. Jeff KingNov 9, 2020
  14. Patrick SteinhardtNov 10, 2020
  15. Junio C HamanoNov 10, 2020
  16. 2/4 update-ref: Allow creation of multiple transactionsPatrick Steinhardt, Nov 9, 2020
  17. 3/4 p1400: Use `git-update-ref --stdin` to test multiple transactionsPatrick Steinhardt, Nov 9, 2020
  18. 4/4 update-ref: Disallow restart of ongoing transactionsPatrick Steinhardt, Nov 9, 2020
  19. Junio C HamanoNov 9, 2020
  20. Jeff KingNov 9, 2020
  21. Junio C HamanoNov 9, 2020
  22. 0/4 update-ref: allow creation of multiple transactionsPatrick Steinhardt, Nov 11, 2020
  23. 1/4 t1400: avoid touching refs on filesystemPatrick Steinhardt, Nov 11, 2020
  24. SZEDER GáborNov 11, 2020
  25. Patrick SteinhardtNov 11, 2020
  26. SZEDER GáborNov 11, 2020
  27. Jeff KingNov 11, 2020
  28. Patrick SteinhardtNov 13, 2020
  29. 2/4 update-ref: allow creation of multiple transactionsPatrick Steinhardt, Nov 11, 2020
  30. 3/4 p1400: use `git-update-ref --stdin` to test multiple transactionsPatrick Steinhardt, Nov 11, 2020
  31. 4/4 update-ref: disallow "start" for ongoing transactionsPatrick Steinhardt, Nov 11, 2020
  32. 0/4 update-ref: allow creation of multiple transactionsPatrick Steinhardt, Nov 13, 2020
  33. 1/4 t1400: avoid touching refs on filesystemPatrick Steinhardt, Nov 13, 2020
  34. Jeff KingNov 13, 2020
  35. Patrick SteinhardtNov 18, 2020
  36. Junio C HamanoNov 18, 2020
  37. 2/4 update-ref: allow creation of multiple transactionsPatrick Steinhardt, Nov 13, 2020
  38. 3/4 p1400: use `git-update-ref --stdin` to test multiple transactionsPatrick Steinhardt, Nov 13, 2020
  39. 4/4 update-ref: disallow "start" for ongoing transactionsPatrick Steinhardt, Nov 13, 2020
  40. Junio C HamanoNov 25, 2020
  41. Jeff KingNov 26, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.