Re: [PATCH v2 1/2] CoC: Update word-wrapping to match upstream

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 4, 2021, 23:43 UTC
Message-ID: <xmqqzh1o5kub.fsf@gitster.c.googlers.com>
In-Reply-To: <20201228171734.30038-2-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 8 quoted lines

> When the CoC document was added in 5cdf2301d4a (add a Code of Conduct
> document, 2019-09-24) it was added from some 1.4 version of the
> document whose word wrapping doesn't match what's currently at [1],
> which matches content/version/1/4/code-of-conduct.md in the CoC
> repository[2].
>
> Let's update our version to match that, to make reading subsequent
> diffs easier.

... because a patch going straight to upstream's 2.0 would have to include the three hunks we see here, that would be a noise because the diff between upstream's 1.4 and 2.0 does not touch these places?

If so, then this step makes sense to me.

> There are no non-whitespace changes here.

Not a comment about this patch, but "git show --word-diff" would still show three hunks with no change highlighted as expected.

I wonder if the word-diff (or color-words) logic should be further taught to squelch out the hunks that do not change anything other than line wrapping and whitespace fuzz.

Thanks.