git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Re* [PATCH v2 2/2] CoC: update to version 2.0 + local changes

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 7, 2021, 23:28 UTC
Message-ID
<nycvar.QRO.7.76.6.2101080028150.2213@tvgsbejvaqbjf.bet>
In-Reply-To
<xmqqft3g463x.fsf@gitster.c.googlers.com>
Hi Junio,
On Mon, 4 Jan 2021, Junio C Hamano wrote:
Show 19 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
> > Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
> >
> >> This change intentionally preserves a warning emitted on "git diff
> >> --check". It's better to make it easily diff-able with upstream than
> >> to fix whitespace changes in our version while we're at it.
> >
> > I think there are only two lines that needs to tolerate trailing
> > whitespaces, and even if we strip them, it should be still easily
> > diff-able with the upstream with --ignore-space-at-eol or whatever
> > appropriate option, so I am not sure if it is worth try "keeping"
> > these whitespace breakage.
>
> In the meantime, I'll insert this as step [1.5/2] while queuing.
>
> In any case, your [2/2] lacks your sign-off, which we eventually
> need to have before applying these patches.  In the meantime, we
> also need to collect Acks on the move to 2.0 from folks.
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Thanks, Dscho

Previous: Junio C HamanoNext: Junio C Hamano
Message 11 of 21 in “CoC: update to 2.0”
  1. CoC: update to 2.0Junio C Hamano, Dec 28, 2020
  2. Derrick StoleeDec 28, 2020
  3. brian m. carlsonDec 28, 2020
  4. 0/2 CoC: update to 2.0 with less upstream divergenceÆvar Arnfjörð Bjarmason, Dec 28, 2020
  5. 2/2 CoC: update to version 2.0 + local changesÆvar Arnfjörð Bjarmason, Dec 28, 2020
  6. Junio C HamanoDec 28, 2020
  7. Elijah NewrenDec 29, 2020
  8. Derrick StoleeDec 29, 2020
  9. Christian CouderDec 30, 2020
  10. Re* [PATCH v2 2/2] CoC: update to version 2.0 + local changesJunio C Hamano, Jan 4, 2021
  11. Johannes SchindelinJan 7, 2021
  12. Junio C HamanoJan 8, 2021
  13. brian m. carlsonJan 8, 2021
  14. Jonathan NiederDec 29, 2020
  15. 1/2 CoC: Update word-wrapping to match upstreamÆvar Arnfjörð Bjarmason, Dec 28, 2020
  16. Jonathan NiederDec 29, 2020
  17. Junio C HamanoJan 4, 2021
  18. Ævar Arnfjörð BjarmasonDec 28, 2020
  19. Junio C HamanoDec 28, 2020
  20. Emily ShafferDec 28, 2020
  21. Pratyush YadavDec 29, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.