Re: [PATCH v3 0/2] index-pack: fsck honor checks
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 1, 2024, 16:44 UTC
- Message-ID
- <xmqqzfwk16ei.fsf@gitster.g>
- In-Reply-To
- <222CEC85-73B0-49CC-BB81-D6E6F36018B3@gmail.com>
John Cai <johncai86@gmail.com> writes:
Show 12 quoted lines
>>> Thanks for clarifying! Would you mind providing a patch to revise the wording >>> here to make it clearer? I would try but I feel like I might get the wording >>> wrong. >> >> I think the wording there is already mostly correct, except maybe make >> everything plural (a tree -> trees, a .gitmodules blob -> .gitmodules >> blobs, hash of that blob -> hashes of those blobs). We might also need >> to modify a test to show that the current code indeed handles the plural >> situation correctly. I don't have time right now to get to this, so >> hopefully someone could pick this up. > > Thanks! It sounds like we may want to tackle this as part of another patch.
Yeah, the existing documentation has been with our users for some time, and it is not ultra urgent to fix it in that sense. I'd say that it can even wait until JTan gets bored with what he's doing and needs some distraction himself ;-)
As long as our collective mind remembers it as #leftoverbits it would be sufficient.
Thanks, both.