Re: [PATCH v3 0/2] index-pack: fsck honor checks
Hi Jonathan,
On 31 Jan 2024, at 17:30, Jonathan Tan wrote:
Show 22 quoted lines
> John Cai <johncai86@gmail.com> writes:
>> Hi Jonathan,
>>
>> On 26 Jan 2024, at 17:13, Jonathan Tan wrote:
>>
>>> Junio C Hamano <gitster@pobox.com> writes:
>>>>> ++--fsck-objects[=<msg-id>=<severity>...]::
>>>>> ++ Die if the pack contains broken objects. If the pack contains a tree
>>>>> ++ pointing to a .gitmodules blob that does not exist, prints the hash of
>>>>> ++ that blob (for the caller to check) after the hash that goes into the
>>>>> ++ name of the pack/idx file (see "Notes").
>
>> Thanks for clarifying! Would you mind providing a patch to revise the wording
>> here to make it clearer? I would try but I feel like I might get the wording
>> wrong.
>
> I think the wording there is already mostly correct, except maybe make
> everything plural (a tree -> trees, a .gitmodules blob -> .gitmodules
> blobs, hash of that blob -> hashes of those blobs). We might also need
> to modify a test to show that the current code indeed handles the plural
> situation correctly. I don't have time right now to get to this, so
> hopefully someone could pick this up.
Thanks! It sounds like we may want to tackle this as part of another patch.
John
John Cai <johncai86@gmail.com>