Re: [PATCH v2 2/2] index-pack: --fsck-objects to take an optional argument for fsck msgs

From: John Cai <johncai86@gmail.com>
Date: Jan 26, 2024, 20:18 UTC
Message-ID: <47AE747C-69E0-467F-9EC6-860E7791C346@gmail.com>
In-Reply-To: <xmqqwmrwm08t.fsf@gitster.g>

Hi Junio,

On 26 Jan 2024, at 13:13, Junio C Hamano wrote:

Show 12 quoted lines

> "John Cai via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> +--fsck-objects[=<msg-ids>=<severity>...]::
>> +	Instructs index-pack to check for broken objects, but unlike `--strict`,
>> +	does not choke on broken links. If `<msg-ids>` is passed, it should be
>> +	a comma-separated list of `<msg-id>=<severity>` where `<msg-id>` and
>> +	`<severity>` are used to change the severity of `fsck` errors e.g.,
>> +	`--strict="missingEmail=ignore,badTagName=ignore"`. See the entry for
>
> In addition to the comment I made in my reply to 1/2, this should
> be `--fsck-objects="missingEmail=ignore,badTagName=ignore"`, I
> think.  Will treak locally.

Good catch. I might as well re-roll this since I forgot to add a Reviewed-by: Christian Couder <christian.couder@gmail.com> trailer to the commits.

>
> Thanks.