Re: [PATCH v6 0/2] show-index: fix uninitialized hash function

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 11, 2024, 03:16 UTC
Message-ID: <xmqqzfm6h33w.fsf@gitster.g>
In-Reply-To: <20241109092739.14276-1-abhijeet.nkt@gmail.com>

Abhijeet Sonar <abhijeet.nkt@gmail.com> writes:

Show 8 quoted lines

> No, I don't think you are. However, I would like to point out that the code
> which I used as the inspiration also does thing the same way:
>
> 	test_expect_success 'pack-object <stdin parsing: [|--revs] with --stdin' '
> 		cat >in <<-EOF &&
> 		$(git -C pack-object-stdin rev-parse one)
> 		$(git -C pack-object-stdin rev-parse two)
> 		EOF

There is a huge difference between one and two, though ;-) If you expect that your new thing may later have to expect more than one line of output, the way you wrote may be easier to extend, but if you know it won't gain any more lines to its output, output from a single command is better written without cat around it.