Re: [PATCH v3] show-index: fix uninitialized hash function

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 28, 2024, 17:42 UTC
Message-ID: <Zx/NE/9HFNr9V2H7@nand.local>
In-Reply-To: <Zx8ijtkn7y6eBQ-n@pks.im>

On Mon, Oct 28, 2024 at 06:35:15AM +0100, Patrick Steinhardt wrote:

Show 11 quoted lines

> > >  test_expect_success !PTHREADS,!FAIL_PREREQS \
> > >  	'index-pack --threads=N or pack.threads=N warns when no pthreads' '
> > >  	test_must_fail git index-pack --threads=2 2>err &&
> > > --
> > > 2.47.0.107.g34b6ce9b30
> >
> > These all look reasonable and as-expected to me. Patrick (CC'd) has been
> > reviewing similar changes elsewhere, so I'd like him to chime in as well
> > on whether or not this looks good to go.
>
> Ah, thanks. I've missed this topic somehow.

Not a problem at all. Thanks for a very helpful review.

Abhijeet: I've gone ahead and marked this in my notes as "expecting
another round" to address the feedback from Patrick. I'll keep my eyes
out for the new version of this patch. Thanks!

Thanks, Taylor