git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 0/2] show-index: fix uninitialized hash function

From
Patrick Steinhardt <ps@pks.im>
Date
Dec 16, 2024, 08:11 UTC
Message-ID
<Z1_gnA2kwRSyCF02@pks.im>
In-Reply-To
<20241109092739.14276-1-abhijeet.nkt@gmail.com>
On Sat, Nov 09, 2024 at 02:57:37PM +0530, Abhijeet Sonar wrote:
Show 43 quoted lines
> That makes sense, applied.
> 
> Abhijeet Sonar (2):
>   show-index: fix uninitialized hash function
>   t5300: add test for 'show-index --object-format'
> 
>  builtin/show-index.c   |  9 +++++++++
>  t/t5300-pack-object.sh | 18 ++++++++++++++++++
>  2 files changed, 27 insertions(+)
> 
> Range-diff against v5:
> 1:  05ee1e2ea5 = 1:  05ee1e2ea5 show-index: fix uninitialized hash function
> 2:  c8a28aae55 ! 2:  778f3ca18e t5300: add test for 'show-index --object-format'
>     @@ t/t5300-pack-object.sh: test_expect_success SHA1 'show-index works OK outside a
>       
>      +for hash in sha1 sha256
>      +do
>     -+	test_expect_success 'setup: show-index works OK outside a repository with hash algo passed in via --object-format' '
>     -+		git init explicit-hash-$hash --object-format=$hash &&
>     -+		test_commit -C explicit-hash-$hash one &&
>     -+
>     -+		cat >in <<-EOF &&
>     -+		$(git -C explicit-hash-$hash rev-parse one)
>     -+		EOF
>     -+
>     -+		git -C explicit-hash-$hash pack-objects explicit-hash-$hash <in
>     -+	'
>     -+
>      +	test_expect_success 'show-index works OK outside a repository with hash algo passed in via --object-format' '
>     ++		test_when_finished "rm -rf explicit-hash-$hash" &&
>     ++		git init --object-format=$hash explicit-hash-$hash &&
>     ++		test_commit -C explicit-hash-$hash one &&
>     ++		git -C explicit-hash-$hash rev-parse one >in &&
>     ++		git -C explicit-hash-$hash pack-objects explicit-hash-$hash <in &&
>      +		idx=$(echo explicit-hash-$hash/explicit-hash-$hash*.idx) &&
>      +		nongit git show-index --object-format=$hash <"$idx" >actual &&
>     -+		test_line_count = 1 actual &&
>     -+
>     -+		rm -rf explicit-hash-$hash
>     ++		test_line_count = 1 actual
>      +	'
>      +done
>      +
Thanks, this version looks good to me.
Patrick
Previous: Junio C HamanoNext: Junio C Hamano
Message 20 of 27 in “show-index: fix uninitialized hash function”
  1. show-index: fix uninitialized hash functionAbhijeet Sonar, Jul 12, 2024
  2. Junio C HamanoJul 12, 2024
  3. show-index: fix uninitialized hash functionAbhijeet Sonar, Jul 15, 2024
  4. Re* [PATCH v2] show-index: fix uninitialized hash functionJunio C Hamano, Jul 15, 2024
  5. show-index: fix uninitialized hash functionAbhijeet Sonar, Oct 26, 2024
  6. Taylor BlauOct 28, 2024
  7. Patrick SteinhardtOct 28, 2024
  8. Taylor BlauOct 28, 2024
  9. show-index: fix uninitialized hash functionAbhijeet Sonar, Nov 1, 2024
  10. Junio C HamanoNov 2, 2024
  11. Abhijeet SonarNov 2, 2024
  12. 0/2 show-index: fix uninitialized hash functionAbhijeet Sonar, Nov 4, 2024
  13. 1/2 show-index: fix uninitialized hash functionAbhijeet Sonar, Nov 4, 2024
  14. 2/2 t5300: add test for 'show-index --object-format'Abhijeet Sonar, Nov 4, 2024
  15. Junio C HamanoNov 5, 2024
  16. 0/2 show-index: fix uninitialized hash functionAbhijeet Sonar, Nov 9, 2024
  17. 1/2 show-index: fix uninitialized hash functionAbhijeet Sonar, Nov 9, 2024
  18. 2/2 t5300: add test for 'show-index --object-format'Abhijeet Sonar, Nov 9, 2024
  19. Junio C HamanoNov 11, 2024
  20. Patrick SteinhardtDec 16, 2024
  21. Junio C HamanoDec 16, 2024
  22. Abhijeet SonarOct 29, 2024
  23. Abhijeet SonarOct 29, 2024
  24. Abhijeet SonarOct 26, 2024
  25. brian m. carlsonJul 15, 2024
  26. Abhijeet SonarJul 15, 2024
  27. Eric SunshineJul 12, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.