git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] docs: fix check-docs with WITH_BREAKING_CHANGES

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 5, 2025, 15:53 UTC
Message-ID
<xmqqzfhzlbie.fsf_-_@gitster.g>
In-Reply-To
<pull.1871.v2.git.1741171357627.gitgitgadget@gmail.com>

We correctly omit builtin/pack-objects.o from BUILTIN_OBJS, but forgot to add "git pack-redundant" on the EXCLUDED_PROGRAMS list, which made "make check-docs" target notice that the command has been removed but still is documented.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 * The command is still listed in the resulting "git help git"
   output, as cmd-list.perl does not yet know which commands on the
   list are to be ignored under WITH_BREAKING_CHANGES.
 Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git c/Makefile w/Makefile
index a9b2de0692..95ac0820e9 100644
--- c/Makefile
+++ w/Makefile
@@ -1283,7 +1283,9 @@ BUILTIN_OBJS += builtin/mv.o
 BUILTIN_OBJS += builtin/name-rev.o
 BUILTIN_OBJS += builtin/notes.o
 BUILTIN_OBJS += builtin/pack-objects.o
-ifndef WITH_BREAKING_CHANGES
+ifdef WITH_BREAKING_CHANGES
+EXCLUDED_PROGRAMS += git-pack-redundant
+else
 BUILTIN_OBJS += builtin/pack-redundant.o
 endif
 BUILTIN_OBJS += builtin/pack-refs.o
Previous: Phillip Wood via GitGitGadgetNext: Phillip Wood
Message 7 of 17 in “docs: fix repository-layout when building with breaking changes”
  1. docs: fix repository-layout when building with breaking changesPhillip Wood via GitGitGadget, Mar 3, 2025
  2. Junio C HamanoMar 3, 2025
  3. Patrick SteinhardtMar 4, 2025
  4. Phillip WoodMar 4, 2025
  5. Junio C HamanoMar 4, 2025
  6. docs: fix repository-layout when building with breaking changesPhillip Wood via GitGitGadget, Mar 5, 2025
  7. docs: fix check-docs with WITH_BREAKING_CHANGESJunio C Hamano, Mar 5, 2025
  8. Phillip WoodMar 7, 2025
  9. Phillip WoodMar 7, 2025
  10. Junio C HamanoMar 7, 2025
  11. Karthik NayakMar 7, 2025
  12. Phillip WoodMar 9, 2025
  13. Phillip WoodMar 9, 2025
  14. Patrick SteinhardtMar 10, 2025
  15. Patrick SteinhardtMar 11, 2025
  16. phillip.wood123@gmail.comMar 12, 2025
  17. Patrick SteinhardtMar 12, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.