git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] docs: fix repository-layout when building with breaking changes

From
Patrick Steinhardt <ps@pks.im>
Date
Mar 4, 2025, 06:35 UTC
Message-ID
<Z8afGexTdlqDnPV8@pks.im>
In-Reply-To
<xmqqbjuivuzm.fsf@gitster.g>
On Mon, Mar 03, 2025 at 10:18:05AM -0800, Junio C Hamano wrote:
Show 14 quoted lines
> "Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
> >     I copied the name from the test prerequisite as I didn't want to have
> >     different names for condition used in the tests and documentation. I do
> >     have some reservations about the naming though as it means we end up
> >     having to use ifdef::!without-breaking-changes[] or test_expect_success
> >     !WITHOUT_BREAKING_CHANGES to document and test breaking changes which is
> >     a double negative.
> 
> It was exactly the first thing that came to my mind when I saw the
> change to the Makefile in the patch.  Unless our breaking changes
> are all removals, which is not likely to be the case in the longer
> term, "without-breaking-changes" would be an invitation for
> confusing double negatives.

I remember not quite being happy with the double-negation myself. I don't mind renaming the prerequisite we have in our test suite for consistency, as well, if you want to do that.

Patrick
Previous: Junio C HamanoNext: Phillip Wood
Message 3 of 17 in “docs: fix repository-layout when building with breaking changes”
  1. docs: fix repository-layout when building with breaking changesPhillip Wood via GitGitGadget, Mar 3, 2025
  2. Junio C HamanoMar 3, 2025
  3. Patrick SteinhardtMar 4, 2025
  4. Phillip WoodMar 4, 2025
  5. Junio C HamanoMar 4, 2025
  6. docs: fix repository-layout when building with breaking changesPhillip Wood via GitGitGadget, Mar 5, 2025
  7. docs: fix check-docs with WITH_BREAKING_CHANGESJunio C Hamano, Mar 5, 2025
  8. Phillip WoodMar 7, 2025
  9. Phillip WoodMar 7, 2025
  10. Junio C HamanoMar 7, 2025
  11. Karthik NayakMar 7, 2025
  12. Phillip WoodMar 9, 2025
  13. Phillip WoodMar 9, 2025
  14. Patrick SteinhardtMar 10, 2025
  15. Patrick SteinhardtMar 11, 2025
  16. phillip.wood123@gmail.comMar 12, 2025
  17. Patrick SteinhardtMar 12, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.