Re: [PATCH] docs: fix check-docs with WITH_BREAKING_CHANGES

From: Patrick Steinhardt <ps@pks.im>
Date: Mar 11, 2025, 14:40 UTC
Message-ID: <Z9BLZWUarN0kC4CQ@pks.im>
In-Reply-To: <Z86Jze2qZ5s5OyOB@pks.im>

On Mon, Mar 10, 2025 at 07:42:25AM +0100, Patrick Steinhardt wrote:

Show 24 quoted lines

> On Sun, Mar 09, 2025 at 10:52:44AM +0000, Phillip Wood wrote:
> > On 07/03/2025 15:07, Phillip Wood wrote:
> > > On 07/03/2025 10:32, Phillip Wood wrote:
> > > 
> > > The diff below stops us from building pack-redundant with
> > > -Dbreaking_changes=true but still builds the documentation. I don't intend
> > > spending any more time one this
> > > 
> > > [...]
> > >
> > >   if get_option('breaking_changes')
> > >     build_options_config.set('WITH_BREAKING_CHANGES', 'YesPlease')
> > > +  add_project_arguments('-DWITH_BREAKING_CHANGES=YesPlease', language :
> > > 'c')
> > 
> > Looking again at this I think it should probably be
> > 
> >     libgit_c_args += '-DWITH_BREAKING_CHANGES=YesPlease'
> > 
> > to match the rest of our meson.build. As a newcomer to meson I find it
> > confusing that the CFLAGS for the build targets are set implicitly by their
> > libgit dependency.
> 
> Yup, that would be preferable indeed, thanks!

To set expectations: do you have the time/intent to work on this and polish it up into a patch? Otherwise I'm happy to pick it up.

Thanks!

Patrick